From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 3/9] xen: arm: handle concatenated root tables in dump_pt_walk Date: Mon, 08 Sep 2014 14:43:41 -0700 Message-ID: <540E230D.6050806@linaro.org> References: <4427aba8dad3155fca151a0b63bfdf78e3a91033.1409847257.git.ian.campbell@citrix.com> <18784a5341e9a17e5ae00d37a2a1339e8f1e4624.1409847257.git.ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <18784a5341e9a17e5ae00d37a2a1339e8f1e4624.1409847257.git.ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org Cc: tim@xen.org, vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 04/09/14 09:14, Ian Campbell wrote: > ARM allows for the concatenation of pages at the root of a p2m (but not a > regular page table) in order to support a larger IPA space than the number of > levels in the P2M would normally support. We use this to support 40-bit guest > addresses. > > Previously we were unable to dump IPAs which were outside the first page of the > root. To fix this we adjust dump_pt_walk to take the machine address of the > page table root instead of expecting the caller to have mapper it. This allows NIT: s/mapper/mapped/ ? [..] > - mappings[root_level] = root; > + if ( nr_root_tables > 1 ) > + { > + /* > + * Concatenated root-level tables. The table number will be > + * the offset at the previous level. It is not possible to > + * concatenate a level-0 root. > + */ > + BUG_ON(root_level == 0); > + root_table = offsets[root_level - 1]; > + printk("Using concatenated root table %d\n", root_table); NIT: %u Other than this 2 minor comments: Reviewed-by: Julien Grall Regards, -- Julien Grall