From: Julien Grall <julien.grall@linaro.org>
To: Tamas K Lengyel <tklengyel@sec.in.tum.de>, xen-devel@lists.xen.org
Cc: ian.campbell@citrix.com, tim@xen.org, ian.jackson@eu.citrix.com,
stefano.stabellini@citrix.com, andres@lagarcavilla.org,
jbeulich@suse.com, dgdegra@tycho.nsa.gov
Subject: Re: [PATCH v4 16/16] tools/tests: Enable xen-access on ARM
Date: Mon, 08 Sep 2014 17:29:05 -0700 [thread overview]
Message-ID: <540E49D1.7080105@linaro.org> (raw)
In-Reply-To: <1409907524-12509-17-git-send-email-tklengyel@sec.in.tum.de>
Hi Tamas,
On 05/09/14 01:58, Tamas K Lengyel wrote:
> On ARM the guest memory doesn't start from 0 and has multiple banks
> of memory, thus we adjust the setting/unsetting routines accordingly.
> We also define the ARM specific test_and_set_bit function.
>
> Signed-off-by: Tamas K Lengyel <tklengyel@sec.in.tum.de>
> ---
> v4: - Take into account multiple guest ram banks on ARM.
> - Move HAS_MEM_ACCESS definition into config/*.mk and only compile
> xen-access when it is defined.
> - Pass CONFIG_X86/CONFIG_ARM flags during compilation in xen-access
> Makefile.
> ---
> config/arm32.mk | 1 +
> config/arm64.mk | 1 +
> config/x86_32.mk | 2 +
> config/x86_64.mk | 2 +
> tools/tests/xen-access/Makefile | 9 +++-
> tools/tests/xen-access/xen-access.c | 94 +++++++++++++++++++++++++++++++++----
> xen/arch/arm/Rules.mk | 1 -
> xen/arch/x86/Rules.mk | 1 -
> 8 files changed, 97 insertions(+), 14 deletions(-)
>
> diff --git a/config/arm32.mk b/config/arm32.mk
> index aa79d22..4a7c259 100644
> --- a/config/arm32.mk
> +++ b/config/arm32.mk
> @@ -13,6 +13,7 @@ HAS_PL011 := y
> HAS_EXYNOS4210 := y
> HAS_OMAP := y
> HAS_NS16550 := y
> +HAS_MEM_ACCESS := y
Why can't you move HAS_MEM_ACCESS directly here in patch #1?
It would make this patch simpler.
--
Julien Grall
prev parent reply other threads:[~2014-09-09 0:29 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 8:58 [PATCH v4 00/16] Mem_event and mem_access for ARM Tamas K Lengyel
2014-09-05 8:58 ` [PATCH v4 01/16] xen: Relocate mem_access and mem_event into common Tamas K Lengyel
2014-09-05 9:14 ` Jan Beulich
2014-09-05 9:45 ` Tamas K Lengyel
2014-09-05 10:07 ` Jan Beulich
2014-09-05 10:36 ` Tamas K Lengyel
2014-09-05 10:48 ` Jan Beulich
2014-09-05 10:52 ` Tamas K Lengyel
2014-09-05 11:26 ` Jan Beulich
2014-09-05 11:30 ` Tamas K Lengyel
2014-09-05 11:46 ` Jan Beulich
2014-09-05 8:58 ` [PATCH v4 02/16] xen: Relocate p2m_mem_access_resume to mem_access common Tamas K Lengyel
2014-09-05 9:16 ` Jan Beulich
2014-09-05 9:25 ` Tamas K Lengyel
2014-09-05 9:43 ` Jan Beulich
2014-09-05 9:48 ` Tamas K Lengyel
2014-09-05 8:58 ` [PATCH v4 03/16] xen: Relocate struct npfec definition into common Tamas K Lengyel
2014-09-05 8:58 ` [PATCH v4 04/16] xen: Relocate mem_event_op domctl and access_op memop " Tamas K Lengyel
2014-09-05 9:23 ` Jan Beulich
2014-09-05 9:29 ` Tamas K Lengyel
2014-09-05 8:58 ` [PATCH v4 05/16] xen/mem_event: Clean out superfluous white-spaces Tamas K Lengyel
2014-09-05 8:58 ` [PATCH v4 06/16] xen/mem_event: Relax error condition on debug builds Tamas K Lengyel
2014-09-05 9:25 ` Jan Beulich
2014-09-05 9:26 ` Tamas K Lengyel
2014-09-05 8:58 ` [PATCH v4 07/16] xen/mem_event: Abstract architecture specific sanity checks Tamas K Lengyel
2014-09-05 9:28 ` Jan Beulich
2014-09-05 9:35 ` Tamas K Lengyel
2014-09-05 9:44 ` Jan Beulich
2014-09-05 9:47 ` Tamas K Lengyel
2014-09-05 8:58 ` [PATCH v4 08/16] xen/mem_access: Abstract architecture specific sanity check Tamas K Lengyel
2014-09-05 9:29 ` Jan Beulich
2014-09-05 9:51 ` Tamas K Lengyel
2014-09-05 8:58 ` [PATCH v4 09/16] xen/arm: p2m type definitions and changes Tamas K Lengyel
2014-09-09 0:06 ` Julien Grall
2014-09-05 8:58 ` [PATCH v4 10/16] xen/arm: Add set access required domctl Tamas K Lengyel
2014-09-09 0:07 ` Julien Grall
2014-09-12 15:54 ` Tamas K Lengyel
2014-09-05 8:58 ` [PATCH v4 11/16] xen/arm: Data abort exception (R/W) mem_events Tamas K Lengyel
2014-09-09 0:25 ` Julien Grall
2014-09-05 8:58 ` [PATCH v4 12/16] xen/arm: Instruction prefetch abort (X) mem_event handling Tamas K Lengyel
2014-09-05 8:58 ` [PATCH v4 13/16] xen/arm: Shatter large pages when using mem_acces Tamas K Lengyel
2014-09-05 8:58 ` [PATCH v4 14/16] xen/arm: Enable the compilation of mem_access and mem_event on ARM Tamas K Lengyel
2014-09-05 8:58 ` [PATCH v4 15/16] tools/libxc: Allocate magic page for mem access " Tamas K Lengyel
2014-09-05 8:58 ` [PATCH v4 16/16] tools/tests: Enable xen-access " Tamas K Lengyel
2014-09-09 0:29 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540E49D1.7080105@linaro.org \
--to=julien.grall@linaro.org \
--cc=andres@lagarcavilla.org \
--cc=dgdegra@tycho.nsa.gov \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=tklengyel@sec.in.tum.de \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).