From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 16/16] tools/tests: Enable xen-access on ARM Date: Mon, 08 Sep 2014 17:29:05 -0700 Message-ID: <540E49D1.7080105@linaro.org> References: <1409907524-12509-1-git-send-email-tklengyel@sec.in.tum.de> <1409907524-12509-17-git-send-email-tklengyel@sec.in.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1409907524-12509-17-git-send-email-tklengyel@sec.in.tum.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel , xen-devel@lists.xen.org Cc: ian.campbell@citrix.com, tim@xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, andres@lagarcavilla.org, jbeulich@suse.com, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org Hi Tamas, On 05/09/14 01:58, Tamas K Lengyel wrote: > On ARM the guest memory doesn't start from 0 and has multiple banks > of memory, thus we adjust the setting/unsetting routines accordingly. > We also define the ARM specific test_and_set_bit function. > > Signed-off-by: Tamas K Lengyel > --- > v4: - Take into account multiple guest ram banks on ARM. > - Move HAS_MEM_ACCESS definition into config/*.mk and only compile > xen-access when it is defined. > - Pass CONFIG_X86/CONFIG_ARM flags during compilation in xen-access > Makefile. > --- > config/arm32.mk | 1 + > config/arm64.mk | 1 + > config/x86_32.mk | 2 + > config/x86_64.mk | 2 + > tools/tests/xen-access/Makefile | 9 +++- > tools/tests/xen-access/xen-access.c | 94 +++++++++++++++++++++++++++++++++---- > xen/arch/arm/Rules.mk | 1 - > xen/arch/x86/Rules.mk | 1 - > 8 files changed, 97 insertions(+), 14 deletions(-) > > diff --git a/config/arm32.mk b/config/arm32.mk > index aa79d22..4a7c259 100644 > --- a/config/arm32.mk > +++ b/config/arm32.mk > @@ -13,6 +13,7 @@ HAS_PL011 := y > HAS_EXYNOS4210 := y > HAS_OMAP := y > HAS_NS16550 := y > +HAS_MEM_ACCESS := y Why can't you move HAS_MEM_ACCESS directly here in patch #1? It would make this patch simpler. -- Julien Grall