From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Ian Campbell" <Ian.Campbell@citrix.com>,
"Mihai Donțu" <mdontu@bitdefender.com>
Cc: keir@xen.org, xen-devel@lists.xensource.com,
Tim Deegan <tim@xen.org>, Don Slutz <dslutz@verizon.com>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH 3/3] xen/tools: script for automatically adjusting the coding style to xen style
Date: Tue, 9 Sep 2014 16:00:38 +0100 [thread overview]
Message-ID: <540F1616.4050000@citrix.com> (raw)
In-Reply-To: <1410274207.8217.221.camel@kazak.uk.xensource.com>
On 09/09/14 15:50, Ian Campbell wrote:
> On Tue, 2014-09-09 at 05:32 +0300, Mihai Donțu wrote:
>> This is a clang-format wrapper script that can be used to do the bulk of the
>> coding style work on a foreign source file. It is not yet complete, but it's
>> sufficient for 98% of the cases.
> I think a lot of people would like to have something along these lines
> available. Don also proposed something recently, see [0]. Not sure what
> the hypervisor maintainers opinion is though, I've CCd a few for input.
>
> I've no prior experience with either clang-format or astyle so I don't
> know which is better, but I do like that clang-format doesn't need a
> second pass in emacs (despite being an emacs user).
>
> Ian.
>
> [0] http://lists.xen.org/archives/html/xen-devel/2014-09/msg00918.html
I have no experience with either, but +1 for the principle. It would
vastly ease certain reviews with a single reference to how to correctly
format for Xen style.
The problem with Xen itself is working out which files have Linux style,
which have Xen style and which are currently a mix of the two, and which
are neither.
The problem could possibly be solved by a grepable tag in the emacs
style block?
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-09-09 15:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 2:22 [PATCH 0/3] xen: add support for skipping the current instruction Mihai Donțu
2014-09-09 2:28 ` [PATCH 1/3] x86: add support for computing the instruction length Mihai Donțu
2014-09-09 8:47 ` Mihai Donțu
2014-09-09 9:44 ` Mihai Donțu
2014-09-09 10:13 ` Masami Hiramatsu
2014-09-09 15:46 ` Mihai Donțu
2014-09-09 16:01 ` Mihai Donțu
2014-09-09 16:25 ` Jan Beulich
2014-09-09 17:14 ` Andrew Cooper
2014-09-09 17:27 ` Mihai Donțu
2014-09-09 17:57 ` Konrad Rzeszutek Wilk
2014-09-09 2:29 ` [PATCH 2/3] x86/hvm: implement hvm_get_insn_length() Mihai Donțu
2014-09-09 2:32 ` [PATCH 3/3] xen/tools: script for automatically adjusting the coding style to xen style Mihai Donțu
2014-09-09 14:50 ` Ian Campbell
2014-09-09 15:00 ` Andrew Cooper [this message]
2014-09-09 19:52 ` Tim Deegan
2014-09-10 10:59 ` Don Slutz
2014-09-10 14:21 ` Don Slutz
2014-09-09 9:47 ` [PATCH 0/3] xen: add support for skipping the current instruction Jan Beulich
2014-09-09 17:00 ` Mihai Donțu
2014-09-09 18:58 ` Tamas K Lengyel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540F1616.4050000@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=dslutz@verizon.com \
--cc=keir@xen.org \
--cc=mdontu@bitdefender.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).