From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 2/9] xen: arm: Implement variable levels
 in dump_pt_walk
Date: Tue, 9 Sep 2014 17:04:13 +0100
Message-ID: <540F24FD.8020503@citrix.com>
References: <4427aba8dad3155fca151a0b63bfdf78e3a91033.1409847257.git.ian.campbell@citrix.com>	<b808d8e29fafb8cb80ed3563cc749b575832db53.1409847257.git.ian.campbell@citrix.com>	<540E1E7C.6030604@linaro.org>
	<1410275064.8217.224.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1410275064.8217.224.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>, Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xen.org, tim@xen.org, vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On 09/09/14 16:04, Ian Campbell wrote:
> On Mon, 2014-09-08 at 14:24 -0700, Julien Grall wrote:
>>> +    /* mappings[root_level] is provided by the caller so don't unmap that */
>>> +    do
>>> +    {
>>> +        unmap_domain_page(mappings[level]);
>>> +    }
>>> +    while( level-- > root_level );
>> NIT: It looks like we commonly use the coding style
>>
>> do
>> {
>> } while ( ... )
> Seems we do. Seems inconsistent with if() and while/do loops to me. Oh
> well.
>
> Ian.

It is to visually differentiate

if ( ... )
{
    ....
}
while ( something unrelated, with a suspicious looking semicolon );

from
do
{
    ....
}
while ( something related to the loop );

~Andrew