Re: [PATCH v2] xen/arm: Correctly support WARN_ON

[Julien Grall <julien.grall@linaro.org>]

Hi Ian,

On 09/09/14 02:19, Ian Campbell wrote:
> On Mon, 2014-09-08 at 12:24 -0700, Julien Grall wrote:
>> On 08/09/14 12:19, Julien Grall wrote:
>>>>
>>>> OOI what is the size increase of the final (stripped) binary with this
>>>> patch?
>>>
>>> I compared the file xen/xen and on both arm32/arm64 the binary is
>>> smaller of about 2%.
>>>
>>> I think this is because previously gcc wasn't merge the string when
>>> BUG_ON was used in inline function.
>>
>> BTW this series won't work correctly because of XSA-102 on ARM64 when
>> WARN_ON/BUG_ON/ASSERT is used in startup code.
>> This is because the "current" is set to a debug sanity value.
>>
>> Do you plan to send the series to add support for 32-bit userspace on
>> 64-bits kernels for Xen 4.5?
>
> I must confess I'd forgotten about it. I'll dig it out and brush the
> cobwebs off ASAP.

Thanks, I saw the series in my inbox. I will give a look today or tomorrow.

> In the meantime can the test at the head of do_trap_hypervisor be
> extended to DTRT with traps from EL2 (i.e. skip the rest of the
> expression)?

I plan to do smth like:

if ( guest_mode(regs) && ... )

Regards,


-- 
Julien Grall