From: "Jürgen Groß" <jgross@suse.com>
To: David Vrabel <david.vrabel@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCHv2] xen: remove DEFINE_XENBUS_DRIVER() macro
Date: Thu, 11 Sep 2014 05:59:28 +0200 [thread overview]
Message-ID: <54111E20.9050901@suse.com> (raw)
In-Reply-To: <54107B84.7070005@citrix.com>
On 09/10/2014 06:25 PM, David Vrabel wrote:
> On 10/09/14 17:00, Konrad Rzeszutek Wilk wrote:
>> On Wed, Sep 10, 2014 at 01:07:49PM +0100, David Vrabel wrote:
>>> The DEFINE_XENBUS_DRIVER() macro looks a bit weird and causes sparse
>>> errors.
>>
>> .. but it is also useful for downstream distros to bolt on Xen patches.
>>
>> Is this urgent? Could it wait until Novell/SuSE has switched over
>> to using pvops and then this can go in?
>
> If the macro didn't cause sparse errors, I could be persuaded to wait.
Couldn't you modify the current macro users to avoid the sparse errors?
E.g. by explicitly specifying the second argument as "NULL" when the
default is desired?
Removing the "+ 0" from evaluation of "drvname" in the macro definition
would enforce specifying "drvname".
Juergen
>
> I do not think we should avoid fixing bugs or improving the readability
> or maintainability of the code to help out someone still using
> non-upstream Xen support.
>
> In general, the cost of maintaining non-upstream forks should not be
> paid for by upstream users/developers.
>
> David
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
prev parent reply other threads:[~2014-09-11 3:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 12:07 [PATCHv2] xen: remove DEFINE_XENBUS_DRIVER() macro David Vrabel
2014-09-10 16:00 ` Konrad Rzeszutek Wilk
2014-09-10 16:25 ` David Vrabel
2014-09-10 16:44 ` Konrad Rzeszutek Wilk
2014-09-11 9:44 ` David Vrabel
2014-09-11 3:59 ` Jürgen Groß [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54111E20.9050901@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jbeulich@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).