From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wen Congyang <wency@cn.fujitsu.com>
Subject: Re: [RFC Patch v3 16/18] update
 libxl__device_disk_from_xs_be() to support blktap device
Date: Thu, 11 Sep 2014 15:58:37 +0800
Message-ID: <5411562D.8000604@cn.fujitsu.com>
References: <1409908261-18682-1-git-send-email-wency@cn.fujitsu.com>	
	<1409908261-18682-17-git-send-email-wency@cn.fujitsu.com>
	<1410176567.10156.201.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1410176567.10156.201.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, xen devel <xen-devel@lists.xen.org>, Shriram Rajagopalan <rshriram@cs.ubc.ca>, Yang Hongyang <yanghy@cn.fujitsu.com>
List-Id: xen-devel@lists.xenproject.org

On 09/08/2014 07:42 PM, Ian Campbell wrote:
> On Fri, 2014-09-05 at 17:10 +0800, Wen Congyang wrote:
>>
>> +int libxl_string_to_format(libxl_ctx *ctx, char *s, libxl_disk_format
>> *format)
>> +{
> 
> This already exists as libxl_disk_format_to_string.

Another question:
We store format:file to tapdisk-params/params. But we store aio if the format
is raw. libxl_disk_format_to_string() doesn't recognize aio...

Is it ok to change the value stored in tapdisk-params/params?

Thanks
Wen Congyang

> 
> Ian.
> 
> .
>