From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 20/29] tools/libxl: Update datacopier to support sending data only Date: Thu, 11 Sep 2014 13:00:57 +0100 Message-ID: <54118EF9.8010607@citrix.com> References: <1410369067-1330-1-git-send-email-andrew.cooper3@citrix.com> <1410369067-1330-21-git-send-email-andrew.cooper3@citrix.com> <1410436609.25388.1.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1410436609.25388.1.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , Wen Congyang , Xen-devel List-Id: xen-devel@lists.xenproject.org On 11/09/14 12:56, Ian Campbell wrote: > On Wed, 2014-09-10 at 18:10 +0100, Andrew Cooper wrote: >> From: Wen Congyang >> >> datacopier is to read some data and write it out. If we >> have some data to send it over network, we cannot use >> datacopier. Update it to support this case. > I'm afraid I'm not sure what this changelog is saying. If we have data > to send over the network then why can't we use datacopier? How does > making this conditional on readfd's validity help that case? datacopier was originally strictly copying data from infd to outfd, until EOF. These patches around here in the series extend datacopier to include "please write this local buffer to outfd", "please read $N bytes from infd to this local buffer", and "please copy exactly $N bytes from infd to outfd", all as asynchronous operations. ~Andrew