From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [v6][PATCH 2/7] tools/libxc: introduce hypercall
 for xc_reserved_device_memory_map
Date: Thu, 11 Sep 2014 16:55:54 +0100
Message-ID: <5411C60A.4090007@citrix.com>
References: <1410328190-6372-1-git-send-email-tiejun.chen@intel.com>	<1410328190-6372-3-git-send-email-tiejun.chen@intel.com>
	<5411DA280200007800034036@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5411DA280200007800034036@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tiejun Chen <tiejun.chen@intel.com>
Cc: kevin.tian@intel.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, Jan Beulich <JBeulich@suse.com>, yang.z.zhang@intel.com
List-Id: xen-devel@lists.xenproject.org

On 11/09/14 16:21, Jan Beulich wrote:
>>>> On 10.09.14 at 07:49, <tiejun.chen@intel.com> wrote:
>> +    if ( errno == ENOBUFS )
>> +        *max_entries = memmap.nr_entries;
>> +
>> +    return rc ? -errno : memmap.nr_entries;
>> +}
> Isn't libxc generally aiming at using POSIX style return values, i.e. -1
> one error with errno indicating the details? Furthermore you're even
> inconsistent with yourself, as you return -1 in an earlier error path.

Furthermore, this in now the 3rd time I have commented on this problem
specifically, across different versions of this series.

Please address all outstanding comments before reposting.

~Andrew