From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v5 02/17] xen: Relocate p2m_mem_access_resume to mem_access common Date: Thu, 11 Sep 2014 13:16:26 -0700 Message-ID: <5412031A.9090802@linaro.org> References: <1410355726-5599-1-git-send-email-tklengyel@sec.in.tum.de> <1410355726-5599-3-git-send-email-tklengyel@sec.in.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1410355726-5599-3-git-send-email-tklengyel@sec.in.tum.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel , xen-devel@lists.xen.org Cc: ian.campbell@citrix.com, tim@xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, andres@lagarcavilla.org, jbeulich@suse.com, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org Hi Tamas, On 10/09/14 06:28, Tamas K Lengyel wrote: > /* Registered with Xen-bound event channel for incoming notifications. */ > diff --git a/xen/include/asm-x86/p2m.h b/xen/include/asm-x86/p2m.h > index 39f235d..2a8970b 100644 > --- a/xen/include/asm-x86/p2m.h > +++ b/xen/include/asm-x86/p2m.h > @@ -601,8 +601,6 @@ void p2m_mem_paging_resume(struct domain *d); > bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla, > struct npfec npfec, > mem_event_request_t **req_ptr); > -/* Resumes the running of the VCPU, restarting the last instruction */ > -void p2m_mem_access_resume(struct domain *d); > I think this comment is useful to keep. I will move it above mem_access_resume prototype in mem_access.h Regards, -- Julien Grall