From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH v2 1/2] x86/HVM: fix miscellaneous aspects of x2APIC emulation
Date: Fri, 12 Sep 2014 09:11:39 +0100 [thread overview]
Message-ID: <5412C6DB0200007800034570@mail.emea.novell.com> (raw)
In-Reply-To: <5411C221.6060109@citrix.com>
>>> On 11.09.14 at 17:39, <andrew.cooper3@citrix.com> wrote:
> On 10/09/14 14:43, Jan Beulich wrote:
>> --- a/xen/arch/x86/hvm/vlapic.c
>> +++ b/xen/arch/x86/hvm/vlapic.c
>> @@ -602,6 +602,7 @@ int hvm_x2apic_msr_read(struct vcpu *v,
>> break;
>>
>> case APIC_ICR2:
>> + case APIC_SELF_IPI:
>
> APIC_EOI is also write-only, generates #GP(0) on on rdmsr, and isn't
> caught by vlapic_read_aligned().
Of course - not sure how I managed to overlook that.
> Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Thanks, but together with the above I actually realized I should do
some further changes in v3.
Jan
next prev parent reply other threads:[~2014-09-12 8:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 13:37 [PATCH v2 0/2] x86/HVM: fix various aspects of x2APIC emulation Jan Beulich
2014-09-10 13:43 ` [PATCH v2 1/2] x86/HVM: fix miscellaneous " Jan Beulich
2014-09-11 15:39 ` Andrew Cooper
2014-09-12 8:11 ` Jan Beulich [this message]
2014-09-10 13:44 ` [PATCH v2 2/2] x86/HVM: fix ID handling " Jan Beulich
2014-09-11 16:28 ` Andrew Cooper
2014-09-12 7:57 ` Jan Beulich
2014-09-18 10:53 ` Tim Deegan
2014-09-18 12:20 ` Jan Beulich
2014-09-18 12:59 ` Tim Deegan
2014-09-18 13:22 ` Jan Beulich
2014-09-18 14:07 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5412C6DB0200007800034570@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).