From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v4 06/16] xen: Convert vmware_port to
	xentrace usage
Date: Fri, 12 Sep 2014 09:10:50 -0400
Message-ID: <5412F0DA.1080606@oracle.com>
References: <1410460610-14759-1-git-send-email-dslutz@verizon.com>
	<1410460610-14759-7-git-send-email-dslutz@verizon.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1410460610-14759-7-git-send-email-dslutz@verizon.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Jun Nakajima <jun.nakajima@intel.com>, Eddie Dong <eddie.dong@intel.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, George Dunlap <George.Dunlap@eu.citrix.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org

On 09/11/2014 02:36 PM, Don Slutz wrote:
> @@ -2080,6 +2080,14 @@ static void svm_vmexit_gp_intercept(struct cpu_user_regs *regs,
>       inst_len = __get_instruction_length_from_list(
>           v, list, ARRAY_SIZE(list), 0);
>   
> +    if ( hvm_long_mode_enabled(v) )
> +        HVMTRACE_LONG2_C4D(TRAP_GP, inst_len, regs->rdx,
> +                           TRC_PAR_LONG(vmcb->exitinfo1),
> +                           TRC_PAR_LONG(vmcb->exitinfo2));
> +    else
> +        HVMTRACE_C4D(TRAP_GP, inst_len, vmcb->exitinfo1, vmcb->exitinfo1,
> +                     vmcb->exitinfo2);

exitinfo1 is used twice. Did you mean regs->rdx for one of them?

-boris

> +
>       rc = vmport_gp_check(regs, v, inst_len, inst_addr,
>                            vmcb->exitinfo1, vmcb->exitinfo2);
>       if ( !rc )