* [PATCH] toolcore: Build in rumprun environment too
@ 2017-10-16 10:17 Ian Jackson
2017-10-16 10:30 ` Wei Liu
0 siblings, 1 reply; 5+ messages in thread
From: Ian Jackson @ 2017-10-16 10:17 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Ian Jackson
Otherwise,
f942a9b4a12081d5f9a4679d06e88cb5d503396e
xentoolcore_restrict_all: "Implement" for xenstore
breaks the build of the tools inside rumprun.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
---
tools/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/Makefile b/tools/Makefile
index 03d326a..59d1c04 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -49,7 +49,7 @@ SUBDIRS-$(OCAML_TOOLS) += ocaml
endif
ifeq ($(CONFIG_RUMP),y)
-SUBDIRS-y := libxc xenstore
+SUBDIRS-y := toolcore libxc xenstore
endif
# For the sake of linking, set the sys-root
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] toolcore: Build in rumprun environment too
2017-10-16 10:17 [PATCH] toolcore: Build in rumprun environment too Ian Jackson
@ 2017-10-16 10:30 ` Wei Liu
2017-10-16 11:25 ` Julien Grall
0 siblings, 1 reply; 5+ messages in thread
From: Wei Liu @ 2017-10-16 10:30 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel, Wei Liu
On Mon, Oct 16, 2017 at 11:17:12AM +0100, Ian Jackson wrote:
> Otherwise,
> f942a9b4a12081d5f9a4679d06e88cb5d503396e
> xentoolcore_restrict_all: "Implement" for xenstore
> breaks the build of the tools inside rumprun.
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] toolcore: Build in rumprun environment too
@ 2017-10-16 11:23 Ian Jackson
2017-10-16 11:24 ` Wei Liu
0 siblings, 1 reply; 5+ messages in thread
From: Ian Jackson @ 2017-10-16 11:23 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu, Ian Jackson
Otherwise,
f942a9b4a12081d5f9a4679d06e88cb5d503396e
xentoolcore_restrict_all: "Implement" for xenstore
breaks the build of the tools inside rumprun.
toolcore is in libs, so we need to add the CONFIG_RUMP special case to
tools/libs/Makefile and add toolcore there.
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
---
v2: toolcore is in libs
---
tools/Makefile | 2 +-
tools/libs/Makefile | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/Makefile b/tools/Makefile
index 03d326a..84d6e3b 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -49,7 +49,7 @@ SUBDIRS-$(OCAML_TOOLS) += ocaml
endif
ifeq ($(CONFIG_RUMP),y)
-SUBDIRS-y := libxc xenstore
+SUBDIRS-y := libs libxc xenstore
endif
# For the sake of linking, set the sys-root
diff --git a/tools/libs/Makefile b/tools/libs/Makefile
index ea9a64d..88901e7 100644
--- a/tools/libs/Makefile
+++ b/tools/libs/Makefile
@@ -10,4 +10,8 @@ SUBDIRS-y += call
SUBDIRS-y += foreignmemory
SUBDIRS-y += devicemodel
+ifeq ($(CONFIG_RUMP),y)
+SUBDIRS-y := toolcore
+endif
+
all clean install distclean uninstall: %: subdirs-%
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] toolcore: Build in rumprun environment too
2017-10-16 11:23 Ian Jackson
@ 2017-10-16 11:24 ` Wei Liu
0 siblings, 0 replies; 5+ messages in thread
From: Wei Liu @ 2017-10-16 11:24 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel, Wei Liu
On Mon, Oct 16, 2017 at 12:23:12PM +0100, Ian Jackson wrote:
> Otherwise,
> f942a9b4a12081d5f9a4679d06e88cb5d503396e
> xentoolcore_restrict_all: "Implement" for xenstore
> breaks the build of the tools inside rumprun.
>
> toolcore is in libs, so we need to add the CONFIG_RUMP special case to
> tools/libs/Makefile and add toolcore there.
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] toolcore: Build in rumprun environment too
2017-10-16 10:30 ` Wei Liu
@ 2017-10-16 11:25 ` Julien Grall
0 siblings, 0 replies; 5+ messages in thread
From: Julien Grall @ 2017-10-16 11:25 UTC (permalink / raw)
To: Wei Liu, Ian Jackson; +Cc: xen-devel
On 16/10/17 11:30, Wei Liu wrote:
> On Mon, Oct 16, 2017 at 11:17:12AM +0100, Ian Jackson wrote:
>> Otherwise,
>> f942a9b4a12081d5f9a4679d06e88cb5d503396e
>> xentoolcore_restrict_all: "Implement" for xenstore
>> breaks the build of the tools inside rumprun.
>>
>> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
Release-acked-by: Julien Grall <julien.grall@linaro.org>
Cheers,
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-16 11:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-16 10:17 [PATCH] toolcore: Build in rumprun environment too Ian Jackson
2017-10-16 10:30 ` Wei Liu
2017-10-16 11:25 ` Julien Grall
-- strict thread matches above, loose matches on Subject: below --
2017-10-16 11:23 Ian Jackson
2017-10-16 11:24 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).