From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86: show page walk when create_bounce_frame() encounters a fault Date: Mon, 15 Sep 2014 16:46:56 +0100 Message-ID: <541709F0.1050000@citrix.com> References: <54130A220200007800034830@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1691755953095222745==" Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XTYWD-0008Vx-SP for xen-devel@lists.xenproject.org; Mon, 15 Sep 2014 15:48:46 +0000 In-Reply-To: <54130A220200007800034830@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Keir Fraser List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --===============1691755953095222745== Content-Type: multipart/alternative; boundary="------------090607090305060409010007" This is a multi-part message in MIME format. --------------090607090305060409010007 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 12/09/2014 13:58, Jan Beulich wrote: > ... getting the native code in sync with the compat mode one. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper > > --- a/xen/arch/x86/x86_64/entry.S > +++ b/xen/arch/x86/x86_64/entry.S > @@ -442,19 +442,30 @@ UNLIKELY_START(z, create_bounce_frame_ba > __UNLIKELY_END(create_bounce_frame_bad_bounce_ip) > movq %rax,UREGS_rip+8(%rsp) > ret > - _ASM_EXTABLE(.Lft2, dom_crash_sync_extable) > - _ASM_EXTABLE(.Lft3, dom_crash_sync_extable) > - _ASM_EXTABLE(.Lft4, dom_crash_sync_extable) > - _ASM_EXTABLE(.Lft5, dom_crash_sync_extable) > - _ASM_EXTABLE(.Lft6, dom_crash_sync_extable) > - _ASM_EXTABLE(.Lft7, dom_crash_sync_extable) > - _ASM_EXTABLE(.Lft8, dom_crash_sync_extable) > - _ASM_EXTABLE(.Lft9, dom_crash_sync_extable) > - _ASM_EXTABLE(.Lft10, dom_crash_sync_extable) > - _ASM_EXTABLE(.Lft11, dom_crash_sync_extable) > - _ASM_EXTABLE(.Lft12, dom_crash_sync_extable) > - _ASM_EXTABLE(.Lft13, dom_crash_sync_extable) > - > + _ASM_EXTABLE(.Lft2, domain_crash_page_fault_32) > + _ASM_EXTABLE(.Lft3, domain_crash_page_fault_24) > + _ASM_EXTABLE(.Lft4, domain_crash_page_fault_8) > + _ASM_EXTABLE(.Lft5, domain_crash_page_fault_16) > + _ASM_EXTABLE(.Lft6, domain_crash_page_fault) > + _ASM_EXTABLE(.Lft7, domain_crash_page_fault) > + _ASM_EXTABLE(.Lft8, domain_crash_page_fault_24) > + _ASM_EXTABLE(.Lft9, domain_crash_page_fault_16) > + _ASM_EXTABLE(.Lft10, domain_crash_page_fault_8) > + _ASM_EXTABLE(.Lft11, domain_crash_page_fault) > + _ASM_EXTABLE(.Lft12, domain_crash_page_fault_8) > + _ASM_EXTABLE(.Lft13, domain_crash_page_fault) > + > +domain_crash_page_fault_32: > + addq $8,%rsi > +domain_crash_page_fault_24: > + addq $8,%rsi > +domain_crash_page_fault_16: > + addq $8,%rsi > +domain_crash_page_fault_8: > + addq $8,%rsi > +domain_crash_page_fault: > + movq %rsi,%rdi > + call show_page_walk > ENTRY(dom_crash_sync_extable) > # Get out of the guest-save area of the stack. > GET_STACK_BASE(%rax) > > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel --------------090607090305060409010007 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit
On 12/09/2014 13:58, Jan Beulich wrote:
... getting the native code in sync with the compat mode one.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>


--- a/xen/arch/x86/x86_64/entry.S
+++ b/xen/arch/x86/x86_64/entry.S
@@ -442,19 +442,30 @@ UNLIKELY_START(z, create_bounce_frame_ba
 __UNLIKELY_END(create_bounce_frame_bad_bounce_ip)
         movq  %rax,UREGS_rip+8(%rsp)
         ret
-        _ASM_EXTABLE(.Lft2,  dom_crash_sync_extable)
-        _ASM_EXTABLE(.Lft3,  dom_crash_sync_extable)
-        _ASM_EXTABLE(.Lft4,  dom_crash_sync_extable)
-        _ASM_EXTABLE(.Lft5,  dom_crash_sync_extable)
-        _ASM_EXTABLE(.Lft6,  dom_crash_sync_extable)
-        _ASM_EXTABLE(.Lft7,  dom_crash_sync_extable)
-        _ASM_EXTABLE(.Lft8,  dom_crash_sync_extable)
-        _ASM_EXTABLE(.Lft9,  dom_crash_sync_extable)
-        _ASM_EXTABLE(.Lft10, dom_crash_sync_extable)
-        _ASM_EXTABLE(.Lft11, dom_crash_sync_extable)
-        _ASM_EXTABLE(.Lft12, dom_crash_sync_extable)
-        _ASM_EXTABLE(.Lft13, dom_crash_sync_extable)
-
+        _ASM_EXTABLE(.Lft2,  domain_crash_page_fault_32)
+        _ASM_EXTABLE(.Lft3,  domain_crash_page_fault_24)
+        _ASM_EXTABLE(.Lft4,  domain_crash_page_fault_8)
+        _ASM_EXTABLE(.Lft5,  domain_crash_page_fault_16)
+        _ASM_EXTABLE(.Lft6,  domain_crash_page_fault)
+        _ASM_EXTABLE(.Lft7,  domain_crash_page_fault)
+        _ASM_EXTABLE(.Lft8,  domain_crash_page_fault_24)
+        _ASM_EXTABLE(.Lft9,  domain_crash_page_fault_16)
+        _ASM_EXTABLE(.Lft10, domain_crash_page_fault_8)
+        _ASM_EXTABLE(.Lft11, domain_crash_page_fault)
+        _ASM_EXTABLE(.Lft12, domain_crash_page_fault_8)
+        _ASM_EXTABLE(.Lft13, domain_crash_page_fault)
+
+domain_crash_page_fault_32:
+        addq  $8,%rsi
+domain_crash_page_fault_24:
+        addq  $8,%rsi
+domain_crash_page_fault_16:
+        addq  $8,%rsi
+domain_crash_page_fault_8:
+        addq  $8,%rsi
+domain_crash_page_fault:
+        movq  %rsi,%rdi
+        call  show_page_walk
 ENTRY(dom_crash_sync_extable)
         # Get out of the guest-save area of the stack.
         GET_STACK_BASE(%rax)






_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--------------090607090305060409010007-- --===============1691755953095222745== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1691755953095222745==--