xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Zheng Li <dev@zheng.li>
To: David Vrabel <david.vrabel@citrix.com>, xen-devel@lists.xenproject.org
Cc: Dave Scott <Dave.Scott@citrix.com>, Joe Jin <joe.jin@oracle.com>,
	"Luis R. Rodriguez" <mcgrof@suse.com>,
	Luonengjun <luonengjun@huawei.com>,
	Fanhenglong <fanhenglong@huawei.com>,
	Ian Jackson <Ian.Jackson@citrix.com>,
	"Liuqiming (John)" <john.liuqiming@huawei.com>
Subject: Re: [PATCH 2/8] oxenstored: add facilities to raise the max open fds uplimit
Date: Tue, 16 Sep 2014 14:05:05 +0100	[thread overview]
Message-ID: <54183581.4030207@zheng.li> (raw)
In-Reply-To: <54180504.7070102@citrix.com>

Hi David,

On 16/09/2014 10:38, David Vrabel wrote:
> On 15/09/14 23:39, Zheng Li wrote:
>> We need to know the system level max open fds so that we won't go above that.
>> Simply setting the limit to RLIM_INFINITY doesn't work on Linux 3.x (EPERM), a
>> patch on this went into the 2.x branch but not 3.x for some reason. Also,
>> getting the system level nr_open is not very straightfoward on 3.x, which is
>> mentioned in the comment inline.
>
>  From sysctl(2):
>
>         "Since Linux 2.6.24, uses of [the sysctl] system call result in
>          warnings in the kernel log.   Remove  it  from  your
>          programs now; use the /proc/sys interface instead."
>
> So using /proc/sys is the correct method and not some awkward workaround.
>

Good to know that, in which case I can remove majority words of the inline comment.

Will do in v2 (and reword the changeset summary).

Thanks,
Zheng

  reply	other threads:[~2014-09-16 13:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-15 22:39 Some oxenstored improvements Zheng Li
2014-09-15 22:39 ` [PATCH 1/8] oxenstored: add a poll-based select mechanism Zheng Li
2014-09-16  9:01   ` David Scott
2014-09-16 13:00     ` Zheng Li
2014-09-15 22:39 ` [PATCH 2/8] oxenstored: add facilities to raise the max open fds uplimit Zheng Li
2014-09-16  9:05   ` Dave Scott
2014-09-16  9:38   ` David Vrabel
2014-09-16 13:05     ` Zheng Li [this message]
2014-09-15 22:39 ` [PATCH 3/8] oxenstored: add a --use-select command line flag Zheng Li
2014-09-15 22:39 ` [PATCH 4/8] oxenstored: catch the error when a connection is already deleted Zheng Li
2014-09-16  9:08   ` Dave Scott
2014-09-15 22:39 ` [PATCH 5/8] oxenstored: use hash table to store socket connections Zheng Li
2014-09-15 22:39 ` [PATCH 6/8] oxenstored: enable domain connection indexing based on eventchn port Zheng Li
2014-09-16  9:16   ` Dave Scott
2014-09-16 13:13     ` Zheng Li
2014-09-15 22:39 ` [PATCH 7/8] oxenstored: only process domain connections that notify us by events Zheng Li
2014-09-16  9:19   ` Dave Scott
2014-09-16 13:34     ` Zheng Li
2014-09-15 22:39 ` [PATCH 8/8] oxenstored: fine tunning the recognition of domain connections with queued input/output Zheng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54183581.4030207@zheng.li \
    --to=dev@zheng.li \
    --cc=Dave.Scott@citrix.com \
    --cc=Ian.Jackson@citrix.com \
    --cc=david.vrabel@citrix.com \
    --cc=fanhenglong@huawei.com \
    --cc=joe.jin@oracle.com \
    --cc=john.liuqiming@huawei.com \
    --cc=luonengjun@huawei.com \
    --cc=mcgrof@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).