From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for-4.5 v2 2/2] xen: arm: Enable physical address space compression (PDX) on arm32 Date: Tue, 16 Sep 2014 13:49:47 -0700 Message-ID: <5418A26B.4080604@linaro.org> References: <1410534866.27902.12.camel@kazak.uk.xensource.com> <1410534923-17209-2-git-send-email-ian.campbell@citrix.com> <54137B04.6080907@linaro.org> <1410896030.23505.34.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1410896030.23505.34.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Roy Franz , stefano.stabellini@eu.citrix.com, tim@xen.org, Fu Wei , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Hi Ian, On 16/09/14 12:33, Ian Campbell wrote: > On Fri, 2014-09-12 at 16:00 -0700, Julien Grall wrote: >>> diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h >>> index 1c3abcf..59b2887 100644 >>> --- a/xen/include/asm-arm/config.h >>> +++ b/xen/include/asm-arm/config.h >>> @@ -126,7 +126,12 @@ >>> #define CONFIG_SEPARATE_XENHEAP 1 >>> >>> #define FRAMETABLE_VIRT_START _AT(vaddr_t,0x02000000) >>> -#define VMAP_VIRT_START _AT(vaddr_t,0x10000000) >>> +#define FRAMETABLE_SIZE MB(128-32) >> >> I would add a comment about why the frametable size is "MB(128-32)". > > There is a big comment just above here which gives an overview of the > virtual address space layout. I don't think it needs repeating here. Hmm right. I haven't look at include/asm-arm/config.h, sorry. Regards, -- Julien Grall