From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wen Congyang <wency@cn.fujitsu.com>
Subject: Re: [RFC Patch v3 18/18] x86/hvm: Always set pending
 event injection when loading VMC[BS] state.
Date: Wed, 17 Sep 2014 15:56:26 +0800
Message-ID: <54193EAA.4020801@cn.fujitsu.com>
References: <1409908261-18682-1-git-send-email-wency@cn.fujitsu.com>
	<1409908261-18682-19-git-send-email-wency@cn.fujitsu.com>
	<54106910.1080207@amd.com>
	<20140911103516.GB31323@deinos.phlegethon.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20140911103516.GB31323@deinos.phlegethon.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Cc: Yang Hongyang <yanghy@cn.fujitsu.com>, Ian Campbell <Ian.Campbell@citrix.com>, Dong Eddie <eddie.dong@intel.com>, Jiang Yunhong <yunhong.jiang@intel.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Jun Nakajima <jun.nakajima@intel.com>, xen devel <xen-devel@lists.xen.org>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Lai Jiangshan <laijs@cn.fujitsu.com>
List-Id: xen-devel@lists.xenproject.org

On 09/11/2014 06:35 PM, Tim Deegan wrote:
> At 10:06 -0500 on 10 Sep (1410340016), Aravind Gopalakrishnan wrote:
>> Hi,
>> You mention that this 'fix' is just copied for svm. But you have not 
>> seen the problem of "VM_ENTRY_INTR_INFO may be valid" (whose svm 
>> equivalent is "vmcb->eventinj.bytes is valid").
>> My concern is that we should test colo mode for svm first, since, if the 
>> problem is never really seen on svm, then fix may not be _necessary_
> 
> I think it's obvious by inspection of the code (and indeed the patch)
> that SVM has the equivalent bug.
> 
>> At this point, my problems are with test setups. I can help testing 
>> scenarios, but as Wen had mentioned, 'colo testing' might be the way to 
>> test.
>> So, if I can get some pointers to how I can reproduce the issue at hand, 
>> then it would be very helpful.
>>
>> (Tim had mentioned we could try to simulate it by running a guest that 
>> takes lot of faults and save-restore another guest over it. However,
>> I am not having much luck following this route. I got a hvm guest to 
>> continuously take SW exceptions on all vcpus and tried to save-restore.
>> I can't see vmcb->eventinj.bytes containing any valid info.)
> 
> Although I think that getting COLO running on SVM is a gret idea, it
> shouldn't block acceptance of this fix.  I've attached a program
> that tests for the bug.  Run it against any HVM guest (and then
> destroy the guest because the test will have corrupted its state).

Hi, Aravind Gopalakrishnan

Do you have time to test this patch with the test program?

Thanks
Wen Congyang

> 
> Cheers,
> 
> Tim.
>