xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Suriyan Ramasami <suriyan.r@gmail.com>,
	Tamas K Lengyel <tamas.lengyel@zentific.com>
Cc: Ian Campbell <ian.campbell@citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [XEN/ARM PATCH v2 1/1] Add support for Exynos secure firmware
Date: Wed, 17 Sep 2014 15:23:46 -0700	[thread overview]
Message-ID: <541A09F2.3080007@linaro.org> (raw)
In-Reply-To: <CANoR_ODrDVDGNW1z-vg_U461cquoQADKkCnUWLyzDsTiLO9pkg@mail.gmail.com>

Hi Suriyan,

On 17/09/14 15:17, Suriyan Ramasami wrote:
>> The code path is the same for the XU and the Arndale for the reset.
>> Let me check into this.
>
>
> This also has been confirmed to happen on the Odroid XU.
> I found that when __initconst is used for exynos_dt_pmu_matches[],
> when the reset code is executed, the memory address for
> exynos_dt_pmu_matches  when accessed generates a DATA abort. I wonder
> if the area where ever the init variables are, are invalidated when
> the dom0 is exiting? I am not sure.
>
> If I remove __initconst from exynos_dt_pmu_mathces[] then there is no
> such issue.
>
> I am wondering if someone has some expert comments on the use of
> __initconst and how that would effect the reset code?

All __initconst variable will live to a separate section. once Xen has 
finished to boot, the section will be freed and Xen may use the memory 
for itself or the guest.

If you plan to use the variables during the reset, then you should drop 
the __initconst.

Regards,

-- 
Julien Grall

  reply	other threads:[~2014-09-17 22:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-12 23:01 [XEN/ARM PATCH v2 1/1] Add support for Exynos secure firmware Suriyan Ramasami
2014-09-12 23:52 ` Julien Grall
2014-09-13  2:08   ` Suriyan Ramasami
2014-09-17  8:37     ` Tamas K Lengyel
2014-09-17 15:38       ` Suriyan Ramasami
2014-09-17 22:17         ` Suriyan Ramasami
2014-09-17 22:23           ` Julien Grall [this message]
2014-09-17 22:39             ` Suriyan Ramasami
2014-09-18 18:30 ` Ian Campbell
2014-09-18 18:44   ` Suriyan Ramasami
2014-09-18 19:06     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541A09F2.3080007@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=suriyan.r@gmail.com \
    --cc=tamas.lengyel@zentific.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).