From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v3 3/4] libxl: add rtds scheduler Date: Thu, 18 Sep 2014 17:24:27 +0100 Message-ID: <541B073B.6010409@eu.citrix.com> References: <1410730649-2417-1-git-send-email-mengxu@cis.upenn.edu> <1410730649-2417-4-git-send-email-mengxu@cis.upenn.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1410730649-2417-4-git-send-email-mengxu@cis.upenn.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Meng Xu , xen-devel@lists.xen.org Cc: ian.campbell@citrix.com, xisisu@gmail.com, stefano.stabellini@eu.citrix.com, lu@cse.wustl.edu, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, ptxlinh@gmail.com, xumengpanda@gmail.com, JBeulich@suse.com, chaowang@wustl.edu, lichong659@gmail.com, dgolomb@seas.upenn.edu List-Id: xen-devel@lists.xenproject.org On 09/14/2014 10:37 PM, Meng Xu wrote: > Add libxl functions to set/get domain's parameters for rtds scheduler > Note: VCPU's information (period, budget) is in microsecond (us). > > Signed-off-by: Meng Xu > Signed-off-by: Sisu Xi Looks good -- once you have the LIBXL_HAS_foo then: Reviewed-by: George Dunlap > --- > tools/libxl/libxl.c | 72 +++++++++++++++++++++++++++++++++++++++++++ > tools/libxl/libxl.h | 1 + > tools/libxl/libxl_types.idl | 2 ++ > 3 files changed, 75 insertions(+) > > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c > index ad3495a..e202c46 100644 > --- a/tools/libxl/libxl.c > +++ b/tools/libxl/libxl.c > @@ -5217,6 +5217,72 @@ static int sched_sedf_domain_set(libxl__gc *gc, uint32_t domid, > return 0; > } > > +static int sched_rtds_domain_get(libxl__gc *gc, uint32_t domid, > + libxl_domain_sched_params *scinfo) > +{ > + struct xen_domctl_sched_rtds sdom; > + int rc; > + > + rc = xc_sched_rtds_domain_get(CTX->xch, domid, &sdom); > + if (rc != 0) { > + LOGE(ERROR, "getting domain sched rtds"); > + return ERROR_FAIL; > + } > + > + libxl_domain_sched_params_init(scinfo); > + > + scinfo->sched = LIBXL_SCHEDULER_RTDS; > + scinfo->period = sdom.period; > + scinfo->budget = sdom.budget; > + > + return 0; > +} > + > +static int sched_rtds_domain_set(libxl__gc *gc, uint32_t domid, > + const libxl_domain_sched_params *scinfo) > +{ > + struct xen_domctl_sched_rtds sdom; > + int rc; > + > + rc = xc_sched_rtds_domain_get(CTX->xch, domid, &sdom); > + if (rc != 0) { > + LOGE(ERROR, "getting domain sched rtds"); > + return ERROR_FAIL; > + } > + > + if (scinfo->period != LIBXL_DOMAIN_SCHED_PARAM_PERIOD_DEFAULT) { > + if (scinfo->period < 1) { > + LOG(ERROR, "VCPU period is not set or out of range, " > + "valid values are larger than 1"); > + return ERROR_INVAL; > + } > + sdom.period = scinfo->period; > + } > + > + if (scinfo->budget != LIBXL_DOMAIN_SCHED_PARAM_BUDGET_DEFAULT) { > + if (scinfo->budget < 1) { > + LOG(ERROR, "VCPU budget is not set or out of range, " > + "valid values are larger than 1"); > + return ERROR_INVAL; > + } > + sdom.budget = scinfo->budget; > + } > + > + if (sdom.budget > sdom.period) { > + LOG(ERROR, "VCPU budget is larger than VCPU period, " > + "VCPU budget should be no larger than VCPU period"); > + return ERROR_INVAL; > + } > + > + rc = xc_sched_rtds_domain_set(CTX->xch, domid, &sdom); > + if (rc < 0) { > + LOGE(ERROR, "setting domain sched rtds"); > + return ERROR_FAIL; > + } > + > + return 0; > +} > + > int libxl_domain_sched_params_set(libxl_ctx *ctx, uint32_t domid, > const libxl_domain_sched_params *scinfo) > { > @@ -5240,6 +5306,9 @@ int libxl_domain_sched_params_set(libxl_ctx *ctx, uint32_t domid, > case LIBXL_SCHEDULER_ARINC653: > ret=sched_arinc653_domain_set(gc, domid, scinfo); > break; > + case LIBXL_SCHEDULER_RTDS: > + ret=sched_rtds_domain_set(gc, domid, scinfo); > + break; > default: > LOG(ERROR, "Unknown scheduler"); > ret=ERROR_INVAL; > @@ -5270,6 +5339,9 @@ int libxl_domain_sched_params_get(libxl_ctx *ctx, uint32_t domid, > case LIBXL_SCHEDULER_CREDIT2: > ret=sched_credit2_domain_get(gc, domid, scinfo); > break; > + case LIBXL_SCHEDULER_RTDS: > + ret=sched_rtds_domain_get(gc, domid, scinfo); > + break; > default: > LOG(ERROR, "Unknown scheduler"); > ret=ERROR_INVAL; > diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h > index 5136d02..00badcc 100644 > --- a/tools/libxl/libxl.h > +++ b/tools/libxl/libxl.h > @@ -1293,6 +1293,7 @@ int libxl_sched_credit_params_set(libxl_ctx *ctx, uint32_t poolid, > #define LIBXL_DOMAIN_SCHED_PARAM_SLICE_DEFAULT -1 > #define LIBXL_DOMAIN_SCHED_PARAM_LATENCY_DEFAULT -1 > #define LIBXL_DOMAIN_SCHED_PARAM_EXTRATIME_DEFAULT -1 > +#define LIBXL_DOMAIN_SCHED_PARAM_BUDGET_DEFAULT -1 > > int libxl_domain_sched_params_get(libxl_ctx *ctx, uint32_t domid, > libxl_domain_sched_params *params); > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > index f1fcbc3..15234d6 100644 > --- a/tools/libxl/libxl_types.idl > +++ b/tools/libxl/libxl_types.idl > @@ -156,6 +156,7 @@ libxl_scheduler = Enumeration("scheduler", [ > (5, "credit"), > (6, "credit2"), > (7, "arinc653"), > + (8, "rtds"), > ]) > > # Consistent with SHUTDOWN_* in sched.h (apart from UNKNOWN) > @@ -318,6 +319,7 @@ libxl_domain_sched_params = Struct("domain_sched_params",[ > ("slice", integer, {'init_val': 'LIBXL_DOMAIN_SCHED_PARAM_SLICE_DEFAULT'}), > ("latency", integer, {'init_val': 'LIBXL_DOMAIN_SCHED_PARAM_LATENCY_DEFAULT'}), > ("extratime", integer, {'init_val': 'LIBXL_DOMAIN_SCHED_PARAM_EXTRATIME_DEFAULT'}), > + ("budget", integer, {'init_val': 'LIBXL_DOMAIN_SCHED_PARAM_BUDGET_DEFAULT'}), > ]) > > libxl_domain_build_info = Struct("domain_build_info",[