Re: [PATCH v3 4/4] xl: introduce rtds scheduler

[George Dunlap <george.dunlap@eu.citrix.com>]

On 09/14/2014 10:37 PM, Meng Xu wrote:
> Add xl command for rtds scheduler
> Note: VCPU's parameter (period, budget) is in microsecond (us).
>
> Signed-off-by: Meng Xu <mengxu@cis.upenn.edu>
> Signed-off-by: Sisu Xi <xisisu@gmail.com>

Minor thing:

> ---
>   docs/man/xl.pod.1         |   35 +++++++++++++
>   tools/libxl/xl.h          |    1 +
>   tools/libxl/xl_cmdimpl.c  |  121 +++++++++++++++++++++++++++++++++++++++++++++
>   tools/libxl/xl_cmdtable.c |    8 +++
>   4 files changed, 165 insertions(+)
>
> diff --git a/docs/man/xl.pod.1 b/docs/man/xl.pod.1
> index 9d1c2a5..4c87292 100644
> --- a/docs/man/xl.pod.1
> +++ b/docs/man/xl.pod.1
> @@ -1035,6 +1035,41 @@ Restrict output to domains in the specified cpupool.
>   
>   =back
>   
> +=item B<sched-rtds> [I<OPTIONS>]
> +
> +Set or get rtds (Real Time Deferrable Server) scheduler parameters.
> +This rt scheduler applies Preemptive Global Earliest Deadline First
> +real-time scheduling algorithm to schedule VCPUs in the system.
> +Each VCPU has a dedicated period and budget.
> +VCPUs in the same domain have the same period and budget (in Xen 4.5).

I think we normally don't include information about specific versions in 
the man pages included in that version; we just describe how that 
specific version works.  (An exception might be something like, "Users 
upgrading from Xen N.M should...", but that wouldn't apply here.)  
Information about specific versions would be included in the wiki or 
other on-line howtos, which are meant to cover multiple versions.

With that change:

Reviewed-by: George Dunlap <george.dunlap@eu.citrix.com>