From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: Roy Franz <roy.franz@linaro.org>,
tim@xen.org, Fu Wei <fu.wei@linaro.org>,
Jan Beulich <JBeulich@suse.com>,
stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH for-4.5 v3 2/3] xen: add helpers for PDX mask initialisation calculations
Date: Thu, 18 Sep 2014 12:16:32 -0700 [thread overview]
Message-ID: <541B2F90.5080008@linaro.org> (raw)
In-Reply-To: <1410988863-15238-2-git-send-email-ian.campbell@citrix.com>
Hi Ian,
On 17/09/14 14:21, Ian Campbell wrote:
> +/* Sets all bits from the most-significant 1-bit down to the LSB */
> +static u64 __init fill_mask(u64 mask)
> +{
> + while (mask & (mask + 1))
> + mask |= mask + 1;
> + return mask;
> +}
> +
> +u64 pdx_init_mask(u64 base_addr)
[..]
> +u64 pdx_region_mask(u64 base, u64 len)
fill_mask is marked as __init. For consistency, those 2 functions should
be marked too.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-09-18 19:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 21:20 [PATCH for-4.5 v3 0/3] Support for sparse physical address space on ARM Ian Campbell
2014-09-17 21:21 ` [PATCH for-4.5 v3 1/3] xen: refactor physical address space compression support into common code Ian Campbell
2014-09-17 21:21 ` [PATCH for-4.5 v3 2/3] xen: add helpers for PDX mask initialisation calculations Ian Campbell
2014-09-18 10:03 ` Jan Beulich
2014-09-18 19:16 ` Julien Grall [this message]
2014-09-22 15:42 ` Ian Campbell
2014-09-22 15:55 ` Julien Grall
2014-09-22 16:28 ` Ian Campbell
2014-09-17 21:21 ` [PATCH for-4.5 v3 3/3] xen: arm: Enable physical address space compression (PDX) on arm Ian Campbell
2014-09-18 19:21 ` Julien Grall
2014-09-18 18:22 ` [PATCH for-4.5 v3 0/3] Support for sparse physical address space on ARM Roy Franz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541B2F90.5080008@linaro.org \
--to=julien.grall@linaro.org \
--cc=JBeulich@suse.com \
--cc=fu.wei@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=roy.franz@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).