From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, tim@xen.org,
xen-devel@lists.xen.org, Roy Franz <roy.franz@linaro.org>,
Jan Beulich <JBeulich@suse.com>, Fu Wei <fu.wei@linaro.org>
Subject: Re: [PATCH for-4.5 v3 2/3] xen: add helpers for PDX mask initialisation calculations
Date: Mon, 22 Sep 2014 16:55:53 +0100 [thread overview]
Message-ID: <54204689.9010903@linaro.org> (raw)
In-Reply-To: <1411400579.26552.13.camel@kazak.uk.xensource.com>
Hi Ian,
On 09/22/2014 04:42 PM, Ian Campbell wrote:
> On Thu, 2014-09-18 at 12:16 -0700, Julien Grall wrote:
>>> +u64 pdx_region_mask(u64 base, u64 len)
>>
>> fill_mask is marked as __init. For consistency, those 2 functions should
>> be marked too.
>
> Just resending that one patch:
>
> --------------------------
>
> From 6a554cc2d7dc076eb4f6ed6f922fa95eea113fa5 Mon Sep 17 00:00:00 2001
> From: Ian Campbell <ian.campbell@citrix.com>
> Date: Tue, 16 Sep 2014 21:01:41 +0100
> Subject: [PATCH] xen: add helpers for PDX mask initialisation calculations
>
> I wanted to make fill_mask a public function so I could use it on ARM, but it
> was actually easier to think of a (semi) reasonable public name for the users
> of it, so that is what I have done.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Acked-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Julien Grall <julien.grall@linaro.org>
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-09-22 15:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 21:20 [PATCH for-4.5 v3 0/3] Support for sparse physical address space on ARM Ian Campbell
2014-09-17 21:21 ` [PATCH for-4.5 v3 1/3] xen: refactor physical address space compression support into common code Ian Campbell
2014-09-17 21:21 ` [PATCH for-4.5 v3 2/3] xen: add helpers for PDX mask initialisation calculations Ian Campbell
2014-09-18 10:03 ` Jan Beulich
2014-09-18 19:16 ` Julien Grall
2014-09-22 15:42 ` Ian Campbell
2014-09-22 15:55 ` Julien Grall [this message]
2014-09-22 16:28 ` Ian Campbell
2014-09-17 21:21 ` [PATCH for-4.5 v3 3/3] xen: arm: Enable physical address space compression (PDX) on arm Ian Campbell
2014-09-18 19:21 ` Julien Grall
2014-09-18 18:22 ` [PATCH for-4.5 v3 0/3] Support for sparse physical address space on ARM Roy Franz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54204689.9010903@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=fu.wei@linaro.org \
--cc=roy.franz@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).