From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for-4.5 v3 2/3] xen: add helpers for PDX mask initialisation calculations Date: Mon, 22 Sep 2014 16:55:53 +0100 Message-ID: <54204689.9010903@linaro.org> References: <1410988836.23505.65.camel@citrix.com> <1410988863-15238-2-git-send-email-ian.campbell@citrix.com> <541B2F90.5080008@linaro.org> <1411400579.26552.13.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1411400579.26552.13.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org, Roy Franz , Jan Beulich , Fu Wei List-Id: xen-devel@lists.xenproject.org Hi Ian, On 09/22/2014 04:42 PM, Ian Campbell wrote: > On Thu, 2014-09-18 at 12:16 -0700, Julien Grall wrote: >>> +u64 pdx_region_mask(u64 base, u64 len) >> >> fill_mask is marked as __init. For consistency, those 2 functions should >> be marked too. > > Just resending that one patch: > > -------------------------- > > From 6a554cc2d7dc076eb4f6ed6f922fa95eea113fa5 Mon Sep 17 00:00:00 2001 > From: Ian Campbell > Date: Tue, 16 Sep 2014 21:01:41 +0100 > Subject: [PATCH] xen: add helpers for PDX mask initialisation calculations > > I wanted to make fill_mask a public function so I could use it on ARM, but it > was actually easier to think of a (semi) reasonable public name for the users > of it, so that is what I have done. > > Signed-off-by: Ian Campbell > Acked-by: Jan Beulich Reviewed-by: Julien Grall Regards, -- Julien Grall