From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v10 11/20] x86/VPMU: Interface for setting PMU mode and flags Date: Mon, 22 Sep 2014 18:48:35 -0400 Message-ID: <5420A743.8070208@oracle.com> References: <1409802080-6160-1-git-send-email-boris.ostrovsky@oracle.com> <1409802080-6160-12-git-send-email-boris.ostrovsky@oracle.com> <541B53BE.4000909@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Tian, Kevin" , "jbeulich@suse.com" , "suravee.suthikulpanit@amd.com" , "Dong, Eddie" , "Aravind.Gopalakrishnan@amd.com" Cc: "andrew.cooper3@citrix.com" , "xen-devel@lists.xen.org" , "keir@xen.org" , "Nakajima, Jun" , "tim@xen.org" List-Id: xen-devel@lists.xenproject.org On 09/22/2014 06:32 PM, Tian, Kevin wrote: >>>> diff --git a/xen/arch/x86/x86_64/compat/entry.S >>>> b/xen/arch/x86/x86_64/compat/entry.S >>>> index ac594c9..8587c46 100644 >>>> --- a/xen/arch/x86/x86_64/compat/entry.S >>>> +++ b/xen/arch/x86/x86_64/compat/entry.S >>>> @@ -417,6 +417,8 @@ ENTRY(compat_hypercall_table) >>>> .quad do_domctl >>>> .quad compat_kexec_op >>>> .quad do_tmem_op >>>> + .quad do_ni_hypercall /* reserved for XenClient */ >>> why XenClient here? >> See include/public/xen.h, hypercall 39. >> > sorry but why it is included in this VPMU patch set? Because I am adding new hypercall (do_xenpmu_op) and if I added it right after do_tmem_op (which is number 38) then it would become number 39. xen.h appears to want to reserve 39 for something else so I had to put a placeholder there. And now do_xenpmu_op becomes number 40. (And to answer your previous email --- I will be posting v11 shortly) -boris