From: Zheng Li <dev@zheng.li>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Dave Scott <Dave.Scott@citrix.com>
Cc: Joe Jin <joe.jin@oracle.com>,
"Luis R. Rodriguez" <mcgrof@suse.com>,
Luonengjun <luonengjun@huawei.com>,
Fanhenglong <fanhenglong@huawei.com>,
"Liuqiming (John)" <john.liuqiming@huawei.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: Some oxenstored improvements (v2)
Date: Tue, 23 Sep 2014 16:57:59 +0100 [thread overview]
Message-ID: <54219887.2040002@zheng.li> (raw)
In-Reply-To: <21537.38060.695761.386357@mariner.uk.xensource.com>
> Dave Scott writes ("Re: Some oxenstored improvements (v2)"):
>> I was just about to Ack the previous set :-) What do the extra patches do?
One is to add a periodical checker as a safe net for the behavioural optimization change in previous set (from exhaustively scanning all the rings to only checking targeted ones). The consideration here is that there might be some ill-behaved clients currently existing in the wild, so it's better to make gradual move.
The other one is a performance improvement related to syslog. Currently, if configured to use syslog, every single line of access log could potentially call sys.stat 3 times, which is a considerable cost given the intensiveness of our access logging.
On 23/09/2014 16:41, Ian Jackson wrote:
> If the previous set are fine I think we should probably apply them
> right away, unless someone thinks there is a reason for waiting.
As the first patch is close related to the some feature in the previous set (as a safety improvement), it's better to just wait a little bit.
Thanks,
Zheng
prev parent reply other threads:[~2014-09-23 15:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 9:31 Some oxenstored improvements (v2) Zheng Li
2014-09-16 9:31 ` [PATCH v2 1/8] oxenstored: add a poll-based select mechanism Zheng Li
2014-09-16 9:31 ` [PATCH v2 2/8] oxenstored: add facilities to raise the max open fds uplimit Zheng Li
2014-09-16 9:31 ` [PATCH v2 3/8] oxenstored: add a --use-select command line flag Zheng Li
2014-09-16 9:31 ` [PATCH v2 4/8] oxenstored: catch the error when a connection is already deleted Zheng Li
2014-09-16 9:31 ` [PATCH v2 5/8] oxenstored: use hash table to store socket connections Zheng Li
2014-09-16 9:31 ` [PATCH v2 6/8] oxenstored: enable domain connection indexing based on eventchn port Zheng Li
2014-09-16 9:31 ` [PATCH v2 7/8] oxenstored: only process domain connections that notify us by events Zheng Li
2014-09-16 9:31 ` [PATCH v2 8/8] oxenstored: fine tunning the recognition of domain connections with queued input/output Zheng Li
2014-09-23 14:32 ` Some oxenstored improvements (v2) Ian Jackson
2014-09-23 15:20 ` Zheng Li
2014-09-23 15:23 ` Dave Scott
2014-09-23 15:41 ` Ian Jackson
2014-09-23 15:57 ` Zheng Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54219887.2040002@zheng.li \
--to=dev@zheng.li \
--cc=Dave.Scott@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=fanhenglong@huawei.com \
--cc=joe.jin@oracle.com \
--cc=john.liuqiming@huawei.com \
--cc=luonengjun@huawei.com \
--cc=mcgrof@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).