From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v4 1/4] x86/HVM: fix miscellaneous aspects of x2APIC emulation Date: Tue, 23 Sep 2014 17:56:43 +0100 Message-ID: <5421A64B.30507@citrix.com> References: <541B09B402000078000363B4@mail.emea.novell.com> <541B0BB402000078000363BF@mail.emea.novell.com> <542020C2.9000304@citrix.com> <542042D902000078000370FC@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XWTOT-0005wp-Su for xen-devel@lists.xenproject.org; Tue, 23 Sep 2014 16:56:49 +0000 In-Reply-To: <542042D902000078000370FC@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , Keir Fraser , Tim Deegan List-Id: xen-devel@lists.xenproject.org T24gMjIvMDkvMTQgMTQ6NDAsIEphbiBCZXVsaWNoIHdyb3RlOgo+Pj4+IE9uIDIyLjA5LjE0IGF0 IDE1OjE0LCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6Cj4+IE9uIDE4LzA5LzE0 IDE1OjQzLCBKYW4gQmV1bGljaCB3cm90ZToKPj4+IEBAIC04OTEsMTYgKzg3NiwzMyBAQCBpbnQg aHZtX3gyYXBpY19tc3Jfd3JpdGUoc3RydWN0IHZjcHUgKnYsCj4+PiAgCj4+PiAgICAgIHN3aXRj aCAoIG9mZnNldCApCj4+PiAgICAgIHsKPj4+IC0gICAgICAgIGludCByYzsKPj4+ICsgICAgY2Fz ZSBBUElDX1RBU0tQUkk6Cj4+PiArICAgIGNhc2UgQVBJQ19FT0k6Cj4+PiArICAgIGNhc2UgQVBJ Q19TUElWOgo+Pj4gKyAgICBjYXNlIEFQSUNfQ01DSToKPj4+ICsgICAgY2FzZSBBUElDX0xWVFQg Li4uIEFQSUNfTFZURVJSOgo+Pj4gKyAgICBjYXNlIEFQSUNfVE1JQ1Q6Cj4+PiArICAgIGNhc2Ug QVBJQ19UTUNDVDoKPj4+ICsgICAgY2FzZSBBUElDX1REQ1I6Cj4+IE1vc3QgKGFsbD8pIG9mIHRo ZXNlIE1TUnMgaGF2ZSByZXNlcnZlZCBiaXRzLCB3aGljaCBzaG91bGQgZmFpbCB3aXRoIGEKPj4g I0dQKDApIGZvciBhdHRlbXB0cyB0byBzZXQuIHZsYXBpY19yZWdfcmVhZCgpIG1hc2tzIG1vc3Qg b2YgdGhlIHJlbGV2YW50Cj4+IGJpdHMsIGJ1dCBkb2Vzbid0IGFwcGVhciB0byBoaXQgYSBtaXNi ZWhhdmluZyBWTS4KPiBQZXJoYXBzLCBidXQgbm90IGluIHRoaXMgcGF0Y2guCgpEb2VzIGl0IG5v dCBjb3VudCB0b3dhcmRzIGZpeGluZyBtaXNjIGFzcGVjdHMgb2YgeDJBUElDIGVtdWxhdGlvbj8K Cj4KPj4+ICsgICAgICAgIGJyZWFrOwo+Pj4gIAo+Pj4gICAgICBjYXNlIEFQSUNfSUNSOgo+Pj4g LSAgICAgICAgcmMgPSB2bGFwaWNfcmVnX3dyaXRlKHYsIEFQSUNfSUNSMiwgKHVpbnQzMl90KSht c3JfY29udGVudCA+PiAzMikpOwo+Pj4gLSAgICAgICAgaWYgKCByYyApCj4+PiAtICAgICAgICAg ICAgcmV0dXJuIHJjOwo+Pj4gKyAgICAgICAgdmxhcGljX3NldF9yZWcodmxhcGljLCBBUElDX0lD UjIsIG1zcl9jb250ZW50ID4+IDMyKTsKPj4+ICAgICAgICAgIGJyZWFrOwo+Pj4gIAo+Pj4gLSAg ICBjYXNlIEFQSUNfSUNSMjoKPj4+IC0gICAgICAgIHJldHVybiBYODZFTVVMX1VOSEFORExFQUJM RTsKPj4+ICsgICAgY2FzZSBBUElDX1NFTEZfSVBJOgo+Pj4gKyAgICAgICAgb2Zmc2V0ID0gQVBJ Q19JQ1I7Cj4+PiArICAgICAgICBtc3JfY29udGVudCA9IEFQSUNfREVTVF9TRUxGIHwgKHVpbnQ4 X3QpbXNyX2NvbnRlbnQ7Cj4+PiArICAgICAgICBicmVhazsKPj4+ICsKPj4+ICsgICAgY2FzZSBB UElDX0VTUjoKPj4+ICsgICAgICAgIGlmICggbXNyX2NvbnRlbnQgKQo+Pj4gKyAgICAgICAgewo+ Pj4gKyAgICAgICAgICAgIHByaW50ayhYRU5MT0dfR19XQVJOSU5HICIlcHY6IG5vbi16ZXJvICgl bHgpIExBUElDIEVTUiB3cml0ZVxuIiwKPj4+ICsgICAgICAgICAgICAgICAgICAgdiwgbXNyX2Nv bnRlbnQpOwo+PiBJIGtub3cgdGhpcyBpcyBqdXN0IG1vdmluZyBhbiBleGlzdGluZyBlcnJvciBt ZXNzYWdlLCBidXQgaXMgaXQgYWN0dWFsbHkKPj4gdXNlZnVsPyBFU1IgaXMgbm8gbW9yZSBzcGVj aWFsIHRoYW4gdGhlIG90aGVyIHJlZ2lzdGVycyB3aXRoIHNvbWUvYWxsCj4+IGJpdHMgcmVzZXJ2 ZWQuCj4gSXQgaXMgZGlmZmVyZW50IGluIHRoYXQgbGVnYWN5IEFQSUMgbW9kZSBhbGxvd3MgdGhl c2UgdG8gYmUgd3JpdHRlbi4KPiBCdXQgeWVzLCBJIHdvbmRlcmVkIGFib3V0IHRoZSB1c2VmdWxu ZXNzIG9mIHRoaXMgbWVzc2FnZSB0b28uCgpFdmVuIGZvciBsZWdhY3kgQVBJQywgdGhlIHZhbHVl IHdyaXR0ZW4gaXMgZGlzY2FyZGVkIGJ5IGhhcmR3YXJlLiAgSQp3b3VsZCBqdXN0IGRyb3AgdGhl IG1lc3NhZ2UuCgo+Cj4+PiBAQCAtOTEwLDcgKzkxMiwxMCBAQCBzdGF0aWMgaW50IHZsYXBpY19y YW5nZShzdHJ1Y3QgdmNwdSAqdiwgCj4+PiAgewo+Pj4gICAgICBzdHJ1Y3QgdmxhcGljICp2bGFw aWMgPSB2Y3B1X3ZsYXBpYyh2KTsKPj4+ICAgICAgdW5zaWduZWQgbG9uZyBvZmZzZXQgID0gYWRk ciAtIHZsYXBpY19iYXNlX2FkZHJlc3ModmxhcGljKTsKPj4+IC0gICAgcmV0dXJuICghdmxhcGlj X2h3X2Rpc2FibGVkKHZsYXBpYykgJiYgKG9mZnNldCA8IFBBR0VfU0laRSkpOwo+Pj4gKwo+Pj4g KyAgICByZXR1cm4gIXZsYXBpY19od19kaXNhYmxlZCh2bGFwaWMpICYmCj4+PiArICAgICAgICAg ICAhdmxhcGljX3gyYXBpY19tb2RlKHZsYXBpYykgJiYKPj4+ICsgICAgICAgICAgIChvZmZzZXQg PCBQQUdFX1NJWkUpOwo+PiBUaGlzIGNoZWNrIGlzIHRvbyByZXN0cmljdGl2ZSwgYXQgbGVhc3Qg b24gSW50ZWwuIEZyb20gU0RNIFZvbCAzIDI5LjQuMy4zCj4+Cj4+ICJBcyBub3RlZCBpbiBTZWN0 aW9uIDI5LjUsIGV4ZWN1dGlvbiBvZiBXUk1TUiB3aXRoIEVDWCA9IDgzRkggKHNlbGYtSVBJCj4+ IE1TUikgY2FuIGxlYWQgdG8gYW4gQVBJQy13cml0ZSBWTSBleGl0Cj4+IGlmIHRoZSDigJx2aXJ0 dWFsLWludGVycnVwdCBkZWxpdmVyeeKAnSBWTS1leGVjdXRpb24gY29udHJvbCBpcyAxLiBUaGUg ZXhpdAo+PiBxdWFsaWZpY2F0aW9uIGZvciBzdWNoIGFuIEFQSUMtd3JpdGUgVk0gZXhpdCBpcwo+ PiAzRjBILiIKPj4KPj4gU28gd2UgY2FuIHN0aWxsIGVuZCB1cCB3YW5kZXJpbmcgdGhlIHZsYXBp YyBNTUlPIGNvZGVwYXRocyBldmVuIGluCj4+IHgyYXBpYyBtb2RlLgo+IE5vdCBleGFjdGx5OiBU aGVzZSBhY2Nlc3NlcyB3b3VsZCBhcnJpdmUgYXQgdmxhcGljX2FwaWN2X3dyaXRlKCkKPiAod2hl cmUgQVBJQ19TRUxGX0lQSSBpcyBiZWluZyBoYW5kbGVkIGV2ZW4gZm9yIHRoZSB4MkFQSUMgY2Fz ZSkKPiBhbmQgaGVuY2Ugd29uJ3QgZ28gdGhlIG5vcm1hbCBNTUlPIHBhdGggKGluY2x1ZGluZyB2 bGFwaWNfcmFuZ2UoKSkuCgpBaCB5ZXMsIHdoaWNoIGJ5cGFzc2VzIHRoZSB2bGFwaWNfcmFuZ2Uo KSB0ZXN0LgoKSW4gd2hpY2ggY2FzZSwgdGhpcyBjaGFuZ2UgYXBwZWFycyBvay4KCn5BbmRyZXcK CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2 ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4u b3JnL3hlbi1kZXZlbAo=