From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2] Avoid clang prior initialization error when listing MTRR flags Date: Wed, 24 Sep 2014 13:31:46 +0100 Message-ID: <5422B9B2.50005@linaro.org> References: <5416E8330200007800034F1B@mail.emea.novell.com> <1411552173-52583-1-git-send-email-saper@saper.info> <1411552173-52583-2-git-send-email-saper@saper.info> <5422D2630200007800038379@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XWlpC-0000e2-Ct for xen-devel@lists.xenproject.org; Wed, 24 Sep 2014 12:37:38 +0000 Received: by mail-wi0-f175.google.com with SMTP id r20so6812022wiv.8 for ; Wed, 24 Sep 2014 05:31:55 -0700 (PDT) In-Reply-To: <5422D2630200007800038379@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Marcin Cieslak Cc: xen-devel@lists.xenproject.org, Ian Campbell List-Id: xen-devel@lists.xenproject.org Hi, On 09/24/2014 01:17 PM, Jan Beulich wrote: >>>> On 24.09.14 at 11:49, wrote: >> Clang 3.4 complains when compiling range of designated range >> initializers: >> >> generic.c:95:32: error: initializer overrides prior initialization of this >> subobject [-Werror,-Winitializer-overrides] >> [MTRR_TYPE_UNCACHABLE] = "uncachable", >> ^~~~~~~~~~~~ >> 6 errors generated. >> >> Signed-off-by: Marcin Cieslak > > Introducing a second lookup level for dealing with a bogus compiler > warning is definitely not the route we want to go. As said before - > a patch to turn off that warning would be fine, but I don't think any > other one would be. I have sent a patch to disable initializer-overrides warning few months ago. See https://patches.linaro.org/27060/. I haven't had time to rework my clang series. It may be interesting to give a look at it and made the change request. IIRC, most of the patches were already acked/reviewed. http://lists.xenproject.org/archives/html/xen-devel/2014-03/msg03239.html Regards, -- Julien Grall