From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH for 4.5 v4 1/4] xen: add real time scheduler rtds Date: Wed, 24 Sep 2014 14:35:56 +0100 Message-ID: <5422C8BC.3050807@eu.citrix.com> References: <1411251228-2093-1-git-send-email-mengxu@cis.upenn.edu> <5422D0A70200007800038343@mail.emea.novell.com> <1411564495.4336.11.camel@Solace.lan> <5422E4150200007800038454@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5422E4150200007800038454@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Dario Faggioli Cc: ian.campbell@citrix.com, xisisu@gmail.com, stefano.stabellini@eu.citrix.com, lu@cse.wustl.edu, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, ptxlinh@gmail.com, xumengpanda@gmail.com, Meng Xu , chaowang@wustl.edu, lichong659@gmail.com, dgolomb@seas.upenn.edu List-Id: xen-devel@lists.xenproject.org On 09/24/2014 02:32 PM, Jan Beulich wrote: >>>> On 24.09.14 at 15:14, wrote: >> On mer, 2014-09-24 at 13:09 +0100, Jan Beulich wrote: >>> Furthermore the function appears to lack serialization with other >>> scheduler operations. >>> >> Not sure what you mean here. There's only one lock serializing >> everything in this scheduler, and it's already taken when this is >> called, the only exception being when it's called from rt_alloc_vdata(). >> >> Is it that one you're referring to? > No. The call path do_domctl() -> sched_adjust() -> rt_dom_cntl() > doesn't take any scheduler related locks afaics. Indeed. -George