From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: KeirFraser <keir@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
coverity@xenproject.org, Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] misc/coverity: Model __builtin_unreachable()
Date: Wed, 24 Sep 2014 15:56:34 +0100 [thread overview]
Message-ID: <5422DBA2.50001@citrix.com> (raw)
In-Reply-To: <5422F66602000078000385F7@mail.emea.novell.com>
On 24/09/14 15:50, Jan Beulich wrote:
>>>> On 24.09.14 at 15:53, <andrew.cooper3@citrix.com> wrote:
>> /*
>> + * Coverity doesn't understand __builtin_unreachable(), which causes it to
>> + * incorrectly find issues based on continuing execution along the false
>> + * branch of an ASSERT().
>> + */
>> +void __builtin_unreachable(void)
>> +{
>> + __coverity_panic__();
>> +}
> And (for those of us without intimate knowledge of Coverity)
> __coverity_panic__() does what? By its name I would conclude
> it terminates the current scan altogether...
>
> Jan
>
__coverity_panic__() is a coverity modelling function defined as "ending
the current execution path". (See https://scan.coverity.com/tune which
might be behind a login)
Its naming is somewhat unfortunate.
~Andrew
prev parent reply other threads:[~2014-09-24 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 13:53 [PATCH] misc/coverity: Model __builtin_unreachable() Andrew Cooper
2014-09-24 14:50 ` Jan Beulich
2014-09-24 14:56 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5422DBA2.50001@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=coverity@xenproject.org \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).