From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] misc/coverity: Model __builtin_unreachable()
Date: Wed, 24 Sep 2014 15:56:34 +0100
Message-ID: <5422DBA2.50001@citrix.com>
References: <1411566794-11652-1-git-send-email-andrew.cooper3@citrix.com>
	<5422F66602000078000385F7@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5422F66602000078000385F7@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: KeirFraser <keir@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, coverity@xenproject.org, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 24/09/14 15:50, Jan Beulich wrote:
>>>> On 24.09.14 at 15:53, <andrew.cooper3@citrix.com> wrote:
>>  /*
>> + * Coverity doesn't understand __builtin_unreachable(), which causes it to
>> + * incorrectly find issues based on continuing execution along the false
>> + * branch of an ASSERT().
>> + */
>> +void __builtin_unreachable(void)
>> +{
>> +    __coverity_panic__();
>> +}
> And (for those of us without intimate knowledge of Coverity)
> __coverity_panic__() does what? By its name I would conclude
> it terminates the current scan altogether...
>
> Jan
>

__coverity_panic__() is a coverity modelling function defined as "ending
the current execution path".  (See https://scan.coverity.com/tune which
might be behind a login)

Its naming is somewhat unfortunate.

~Andrew