Re: [PATCH for-4.5 v6 02/16] tools: Add vmware_hw support

[Don Slutz <dslutz@verizon.com>]

On 09/24/14 10:44, George Dunlap wrote:
> On Sat, Sep 20, 2014 at 7:07 PM, Don Slutz <dslutz@verizon.com> wrote:
>> This is used to set HVM_PARAM_VMWARE_HW. It is set to the VMware
>> virtual hardware version.
>>
>> Currently 0, 3-4, 6-11 are good values.  However the code only
>> checks for == 0 or != 0.
>>
>> If non-zero then
>>    default VGA to VMware's VGA.
>>
>> Also now allows vga=vmware
>>
>> Signed-off-by: Don Slutz <dslutz@verizon.com>
> [snip]
>> diff --git a/docs/misc/hypervisor-cpuid.markdown b/docs/misc/hypervisor-cpuid.markdown
>> new file mode 100644
>> index 0000000..901a4e1
>> --- /dev/null
>> +++ b/docs/misc/hypervisor-cpuid.markdown
>> @@ -0,0 +1,28 @@
>> +Hypervisor Cpuid
>> +================
>> +
>> +The support of hypervisor cpuid leaves has not been agreed to.
>> +Other then the range 0x40000000 to 0x400000ff can be used by
>> +hypervisors.
>> +
>> +MicroSoft Hyper-V (AKA viridian) currently must be at 0x40000000.
>> +
>> +VMware currently must be at 0x40000000.
>> +
>> +KVM currently must be at 0x40000000 (from Seabios).
>> +
>> +Xen can be found at the first otherwise unused 0x100 aligned
>> +offset between 0x40000000 and 0x40010000.
> So Xen is the only kid on the block who plays nice, huh?

Yup.

>> @@ -555,7 +558,12 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
>>               break;
>>           case LIBXL_VGA_INTERFACE_TYPE_NONE:
>>               break;
>> -        }
>> +        case LIBXL_VGA_INTERFACE_TYPE_VMWARE:
>> +            flexarray_append_pair(dm_args, "-device",
>> +                GCSPRINTF("vmware-svga,vgamem_mb=%d",
>> +                libxl__sizekb_to_mb(b_info->video_memkb)));
>> +            break;
>> +            }
> Nit: You screwed up the indentation here.

Will fix.
    -Don Slutz

> Other than that, looks good (with IanC's suggestions).
>
>   -George