From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH for-4.5 v6 02/16] tools: Add vmware_hw
	support
Date: Wed, 24 Sep 2014 17:06:58 -0400
Message-ID: <54233272.7070407@terremark.com>
References: <1411236447-7435-1-git-send-email-dslutz@verizon.com>	<1411236447-7435-3-git-send-email-dslutz@verizon.com>
	<CAFLBxZbfNMC1aL1aWdvzi2tQ+F4OsJagHOJaGM8JW-4FTJJcoA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAFLBxZbfNMC1aL1aWdvzi2tQ+F4OsJagHOJaGM8JW-4FTJJcoA@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: George Dunlap <George.Dunlap@eu.citrix.com>, Don Slutz <dslutz@verizon.com>
Cc: Tim Deegan <tim@xen.org>, Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Eddie Dong <eddie.dong@intel.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Jan Beulich <jbeulich@suse.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jun Nakajima <jun.nakajima@intel.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org

On 09/24/14 10:44, George Dunlap wrote:
> On Sat, Sep 20, 2014 at 7:07 PM, Don Slutz <dslutz@verizon.com> wrote:
>> This is used to set HVM_PARAM_VMWARE_HW. It is set to the VMware
>> virtual hardware version.
>>
>> Currently 0, 3-4, 6-11 are good values.  However the code only
>> checks for == 0 or != 0.
>>
>> If non-zero then
>>    default VGA to VMware's VGA.
>>
>> Also now allows vga=vmware
>>
>> Signed-off-by: Don Slutz <dslutz@verizon.com>
> [snip]
>> diff --git a/docs/misc/hypervisor-cpuid.markdown b/docs/misc/hypervisor-cpuid.markdown
>> new file mode 100644
>> index 0000000..901a4e1
>> --- /dev/null
>> +++ b/docs/misc/hypervisor-cpuid.markdown
>> @@ -0,0 +1,28 @@
>> +Hypervisor Cpuid
>> +================
>> +
>> +The support of hypervisor cpuid leaves has not been agreed to.
>> +Other then the range 0x40000000 to 0x400000ff can be used by
>> +hypervisors.
>> +
>> +MicroSoft Hyper-V (AKA viridian) currently must be at 0x40000000.
>> +
>> +VMware currently must be at 0x40000000.
>> +
>> +KVM currently must be at 0x40000000 (from Seabios).
>> +
>> +Xen can be found at the first otherwise unused 0x100 aligned
>> +offset between 0x40000000 and 0x40010000.
> So Xen is the only kid on the block who plays nice, huh?

Yup.

>> @@ -555,7 +558,12 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
>>               break;
>>           case LIBXL_VGA_INTERFACE_TYPE_NONE:
>>               break;
>> -        }
>> +        case LIBXL_VGA_INTERFACE_TYPE_VMWARE:
>> +            flexarray_append_pair(dm_args, "-device",
>> +                GCSPRINTF("vmware-svga,vgamem_mb=%d",
>> +                libxl__sizekb_to_mb(b_info->video_memkb)));
>> +            break;
>> +            }
> Nit: You screwed up the indentation here.

Will fix.
    -Don Slutz

> Other than that, looks good (with IanC's suggestions).
>
>   -George