From: "Jan Beulich" <JBeulich@suse.com>
To: Roy Franz <roy.franz@linaro.org>
Cc: keir <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>,
tim <tim@xen.org>, xen-devel <xen-devel@lists.xen.org>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Fu Wei <fu.wei@linaro.org>
Subject: Re: [PATCH for-4.5 V7 14/14] Add ARM EFI boot support
Date: Fri, 26 Sep 2014 07:28:40 +0100 [thread overview]
Message-ID: <542523B8020000780003963F@mail.emea.novell.com> (raw)
In-Reply-To: <CAFECyb-ZrZB=DbbEgCvRfG11=+pbKj+t2mqeMpv_ngaggEAgrw@mail.gmail.com>
>>> On 25.09.14 at 19:05, <roy.franz@linaro.org> wrote:
> On Thu, Sep 25, 2014 at 3:49 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 25.09.14 at 03:42, <roy.franz@linaro.org> wrote:
>>> --- a/xen/common/efi/runtime.c
>>> +++ b/xen/common/efi/runtime.c
>>> @@ -4,17 +4,22 @@
>>> #include <xen/guest_access.h>
>>> #include <xen/irq.h>
>>> #include <xen/time.h>
>>> -#include <asm/mc146818rtc.h>
>>> +
>>> +extern spinlock_t rtc_lock;
>>
>> No extern declarations in .c files for things being defined in other .c
>> files please.
>
> OK, I'll have to look at making asm/mc146818rtc.h a common file, or
> moving the extern declaration from that x86 specific include file to a
> common one.
> (or #ifdef CONFIG_X86 this and the spinlock, but that's not nice either.)
Just like you introduced efi-boot.h (which really should have been
just boot.h, but I noticed this only when already having been
through most of the part that I committed yesterday), we'll need
runtime.h anyway sooner or later, and that's where the #include
should get moved imo (even if for now this may end up being the
only content of that file).
Jan
prev parent reply other threads:[~2014-09-26 6:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 1:42 [PATCH for-4.5 V7 00/14] arm64 EFI stub Roy Franz
2014-09-25 1:42 ` [PATCH for-4.5 V7 01/14] x86/EFI: fix freeing of uninitialized pointer Roy Franz
2014-09-25 1:42 ` [PATCH for-4.5 V7 02/14] move x86 EFI boot/runtime code to common/efi Roy Franz
2014-09-25 1:42 ` [PATCH for-4.5 V7 03/14] Move x86 specific funtions/variables to arch header Roy Franz
2014-09-25 1:42 ` [PATCH for-4.5 V7 04/14] create arch functions to allocate memory for and process EFI memory map Roy Franz
2014-09-25 1:42 ` [PATCH for-4.5 V7 05/14] Add architecture functions for pre/post ExitBootServices Roy Franz
2014-09-25 1:42 ` [PATCH for-4.5 V7 06/14] Add efi_arch_cfg_file_early/late() to handle arch specific cfg file fields Roy Franz
2014-09-25 1:42 ` [PATCH for-4.5 V7 07/14] Add efi_arch_handle_cmdline() for processing commandline Roy Franz
2014-09-25 1:42 ` [PATCH for-4.5 V7 08/14] Move x86 specific disk probing code Roy Franz
2014-09-25 1:42 ` [PATCH for-4.5 V7 09/14] Create arch functions for console and video init Roy Franz
2014-09-25 1:42 ` [PATCH for-4.5 V7 10/14] Add efi_arch_memory() for arch specific memory setup Roy Franz
2014-09-25 1:42 ` [PATCH for-4.5 V7 11/14] Add arch specific module handling to read_file() Roy Franz
2014-09-25 10:34 ` Jan Beulich
2014-09-25 16:44 ` Roy Franz
2014-09-25 18:52 ` Roy Franz
2014-09-26 0:25 ` Roy Franz
2014-09-26 6:25 ` Jan Beulich
2014-09-25 1:42 ` [PATCH for-4.5 V7 12/14] Add several misc. arch functions for EFI boot code Roy Franz
2014-09-25 1:42 ` [PATCH for-4.5 V7 13/14] Add efi_arch_use_config_file() function to control use of config file Roy Franz
2014-09-25 1:42 ` [PATCH for-4.5 V7 14/14] Add ARM EFI boot support Roy Franz
2014-09-25 10:49 ` Jan Beulich
2014-09-25 17:05 ` Roy Franz
2014-09-26 6:28 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542523B8020000780003963F@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=fu.wei@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=roy.franz@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).