From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, Tim Deegan <tim@xen.org>
Cc: Keir Fraser <keir@xen.org>, Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH for-4.5 1/2] xen/vsprintf: Introduce %*ph extended format specifier for hex buffers
Date: Fri, 26 Sep 2014 12:57:34 +0100 [thread overview]
Message-ID: <542570CE02000078000399BA@mail.emea.novell.com> (raw)
In-Reply-To: <20140926114925.GA35563@deinos.phlegethon.org>
>>> On 26.09.14 at 13:49, <tim@xen.org> wrote:
> At 11:10 +0100 on 26 Sep (1411726206), Andrew Cooper wrote:
>> + for ( i = 0; i < nr_bytes; ++i )
>> + {
>> + /* Each byte: 2 chars, 0-padded, base 16, no hex prefix. */
>> + str = number(str, end, hex_buffer[i], 16, 2, -1, ZEROPAD);
>> + if ( str < end )
>
> (str < end && i + 1 < nr_bytes) to avoid a trailing space?
Not exactly, as the increment of str must then also be suppressed.
Jan
next prev parent reply other threads:[~2014-09-26 11:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 10:10 [PATCH for-4.5 0/2] Improve "Emulation failed" error message Andrew Cooper
2014-09-26 10:10 ` [PATCH for-4.5 1/2] xen/vsprintf: Introduce %*ph extended format specifier for hex buffers Andrew Cooper
2014-09-26 11:32 ` Jan Beulich
2014-09-26 12:16 ` Andrew Cooper
2014-09-26 12:31 ` Jan Beulich
2014-09-26 12:32 ` Andrew Cooper
2014-09-26 11:49 ` Tim Deegan
2014-09-26 11:57 ` Jan Beulich [this message]
2014-09-26 10:10 ` [PATCH for-4.5 2/2] x86/hvm: Improve "Emulation failed @" error messages Andrew Cooper
2014-09-26 11:39 ` Jan Beulich
2014-09-26 12:04 ` Andrew Cooper
2014-09-26 12:36 ` Jan Beulich
2014-09-26 12:53 ` Andrew Cooper
2014-09-26 12:05 ` Tim Deegan
2014-09-26 12:09 ` Andrew Cooper
2014-09-26 12:41 ` Tim Deegan
2014-09-26 12:57 ` Andrew Cooper
2014-09-26 13:06 ` Jan Beulich
2014-09-26 13:16 ` Andrew Cooper
2014-09-26 13:32 ` Jan Beulich
2014-09-26 14:15 ` [PATCH for-4.5 0/2] Improve "Emulation failed" error message Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542570CE02000078000399BA@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).