xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Zheng Li <dev@zheng.li>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Dave Scott <Dave.Scott@citrix.com>, Joe Jin <joe.jin@oracle.com>,
	"Luis R. Rodriguez" <mcgrof@suse.com>,
	Luonengjun <luonengjun@huawei.com>,
	Fanhenglong <fanhenglong@huawei.com>,
	"Liuqiming (John)" <john.liuqiming@huawei.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 9/9] oxenstored: reduce syslog call overhead (fix typo)
Date: Fri, 26 Sep 2014 16:33:32 +0100	[thread overview]
Message-ID: <5425874C.2010203@zheng.li> (raw)
In-Reply-To: <21541.33606.743491.572799@mariner.uk.xensource.com>

Hi Ian,

On 26/09/2014 16:16, Ian Jackson wrote:
> Zheng Li writes ("Re: [PATCH v3 9/9] oxenstored: reduce syslog call overhead (fix typo)"):
>> Setting up the TZ environment varialbe to avoid stat calls.
> ...
>> +		if not tz_is_set then Unix.putenv "TZ" ":/etc/localtime" in
>
> I wasn't aware of this syntax.  Can you point me to its specification ?

Please see the 3rd format (:characters format) in the linked document below

http://www.gnu.org/software/libc/manual/html_node/TZ-Variable.html

Also a similar issue reported on stackoverflow and discussion

http://stackoverflow.com/questions/4554271/how-to-avoid-excessive-stat-etc-localtime-calls-in-strftime-on-linux

I've manually tested the change. With TZ set, strace no longer shows the intensive stat calls, and the timestamps seem to be correct wrt the local time setting.

Cheers,
Zheng

  reply	other threads:[~2014-09-26 15:33 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25 17:34 Some oxenstored improvements (v3) Zheng Li
2014-09-25 17:34 ` [PATCH v3 1/9] oxenstored: add a poll-based select mechanism Zheng Li
2014-09-25 17:34 ` [PATCH v3 2/9] oxenstored: add facilities to raise the max open fds uplimit Zheng Li
2014-09-25 17:34 ` [PATCH v3 3/9] oxenstored: add a --use-select command line flag Zheng Li
2014-09-25 17:34 ` [PATCH v3 4/9] oxenstored: catch the error when a connection is already deleted Zheng Li
2014-09-25 17:34 ` [PATCH v3 5/9] oxenstored: use hash table to store socket connections Zheng Li
2014-09-25 17:34 ` [PATCH v3 6/9] oxenstored: enable domain connection indexing based on eventchn port Zheng Li
2014-09-25 17:35 ` [PATCH v3 7/9] oxenstored: only process domain connections that notify us by events Zheng Li
2014-09-25 17:35 ` [PATCH v3 8/9] oxenstored: add a safe net mechanism for existing ill-behaved clients Zheng Li
2014-09-25 17:35 ` [PATCH v3 9/9] oxenstored: reduce syslog call overhead Zheng Li
2014-09-25 21:00   ` [PATCH v3 9/9] oxenstored: reduce syslog call overhead (fix typo) Zheng Li
2014-09-26 15:16     ` Ian Jackson
2014-09-26 15:33       ` Zheng Li [this message]
2014-09-26 15:57         ` Ian Jackson
2014-09-26 16:29           ` Zheng Li
2014-09-26 16:37             ` Ian Jackson
2014-09-26 16:38             ` Zheng Li
2014-09-29 14:37 ` Some oxenstored improvements (v3) Konrad Rzeszutek Wilk
2014-09-29 20:55   ` Dave Scott
2014-09-30 10:21     ` Zheng Li
2014-10-07 13:24     ` Konrad Rzeszutek Wilk
2014-10-08 12:59       ` Dave Scott
2014-10-08 13:01         ` Konrad Rzeszutek Wilk
2014-10-08 13:42           ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5425874C.2010203@zheng.li \
    --to=dev@zheng.li \
    --cc=Dave.Scott@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=fanhenglong@huawei.com \
    --cc=joe.jin@oracle.com \
    --cc=john.liuqiming@huawei.com \
    --cc=luonengjun@huawei.com \
    --cc=mcgrof@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).