From: "Jan Beulich" <JBeulich@suse.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: xen-devel@lists.xenproject.org, Andrew Jones <drjones@redhat.com>,
Paul Durrant <paul.durrant@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH for-4.5 v2] x86/hvm: remove stray ioreq_server.lock lock release from hvm_ioreq_server_init()
Date: Fri, 26 Sep 2014 14:44:27 +0100 [thread overview]
Message-ID: <542589DB0200007800039B57@mail.emea.novell.com> (raw)
In-Reply-To: <1411738038-3278-1-git-send-email-vkuznets@redhat.com>
>>> On 26.09.14 at 15:27, <vkuznets@redhat.com> wrote:
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -993,7 +993,6 @@ static int hvm_ioreq_server_init(struct hvm_ioreq_server *s, struct domain *d,
> hvm_ioreq_server_free_rangesets(s, is_default);
>
> fail1:
> - spin_unlock(&d->arch.hvm_domain.ioreq_server.lock);
> return rc;
> }
I'd really like to see the fail1 label gone with this, perhaps at once
renaming the others to "fail_map" and "fail_add". And please also
shorten the title to e.g. "x86/hvm: remove stray lock release from
hvm_ioreq_server_init()" - after all there's only one lock being
released there right now, so this is unambiguous.
Jan
prev parent reply other threads:[~2014-09-26 13:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 13:27 [PATCH for-4.5 v2] x86/hvm: remove stray ioreq_server.lock lock release from hvm_ioreq_server_init() Vitaly Kuznetsov
2014-09-26 13:44 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542589DB0200007800039B57@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=drjones@redhat.com \
--cc=ian.campbell@citrix.com \
--cc=paul.durrant@citrix.com \
--cc=vkuznets@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).