From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH for-4.5 v2] x86/hvm: remove stray ioreq_server.lock lock release from hvm_ioreq_server_init() Date: Fri, 26 Sep 2014 14:44:27 +0100 Message-ID: <542589DB0200007800039B57@mail.emea.novell.com> References: <1411738038-3278-1-git-send-email-vkuznets@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XXVoz-0008Ci-Di for xen-devel@lists.xenproject.org; Fri, 26 Sep 2014 13:44:29 +0000 In-Reply-To: <1411738038-3278-1-git-send-email-vkuznets@redhat.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Vitaly Kuznetsov Cc: xen-devel@lists.xenproject.org, Andrew Jones , Paul Durrant , Ian Campbell List-Id: xen-devel@lists.xenproject.org >>> On 26.09.14 at 15:27, wrote: > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -993,7 +993,6 @@ static int hvm_ioreq_server_init(struct hvm_ioreq_server *s, struct domain *d, > hvm_ioreq_server_free_rangesets(s, is_default); > > fail1: > - spin_unlock(&d->arch.hvm_domain.ioreq_server.lock); > return rc; > } I'd really like to see the fail1 label gone with this, perhaps at once renaming the others to "fail_map" and "fail_add". And please also shorten the title to e.g. "x86/hvm: remove stray lock release from hvm_ioreq_server_init()" - after all there's only one lock being released there right now, so this is unambiguous. Jan