From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zheng Li <dev@zheng.li>
Subject: Re: [PATCH v3 9/9] oxenstored: reduce syslog call
	overhead (fix typo)
Date: Fri, 26 Sep 2014 17:38:49 +0100
Message-ID: <54259699.70700@zheng.li>
References: <1411666502-23709-10-git-send-email-dev@zheng.li>	<1411678822-26528-1-git-send-email-dev@zheng.li>	<21541.33606.743491.572799@mariner.uk.xensource.com>	<5425874C.2010203@zheng.li>
	<21541.36072.303567.573538@mariner.uk.xensource.com>
	<54259480.3090108@zheng.li>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <dev@zheng.li>) id 1XXYXl-0005rL-7i
	for xen-devel@lists.xenproject.org; Fri, 26 Sep 2014 16:38:53 +0000
In-Reply-To: <54259480.3090108@zheng.li>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Dave Scott <Dave.Scott@citrix.com>, Joe Jin <joe.jin@oracle.com>, "Luis R. Rodriguez" <mcgrof@suse.com>, Luonengjun <luonengjun@huawei.com>, Fanhenglong <fanhenglong@huawei.com>, "Liuqiming (John)" <john.liuqiming@huawei.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org



On 26/09/2014 17:29, Zheng Li wrote:
> On 26/09/2014 16:57, Ian Jackson wrote:
>> Zheng Li writes ("Re: [PATCH v3 9/9] oxenstored: reduce syslog call overhead (fix typo)"):
>>> Please see the 3rd format (:characters format) in the linked document below
>>> http://www.gnu.org/software/libc/manual/html_node/TZ-Variable.html
>>
>> That's great for glibc-based guests.  But what about the BSDs ?
>
> This code does xenstored access logging in Dom0. Looking at the supported Dom0 distros page on the wiki, its seems that only NetBSD is the concern here?
>
>> I looked at
>>    http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08
>> and it just says that the : syntax is `implementation defined'.
>
> I guess most BSDs adopt the same semantics. I searched for NetBSD libc manual and found this (starting from "if the value does not begin with a colon ...")

Sorry, should be "if the value begins with a colon ...". From what I read, even if it doesn't start with a colon, it will still be treated as a time conversion file as the first resort.

Also, the syslog implementation on BSD might be different (e.g. might not have the "stat" issue at all). So as far as setting the TZ variable won't cause any problem for the xenstored process, we should be fine with it.

Cheers,
Zheng