From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v12 for-xen-4.5 15/20] x86/VPMU: Add support
 for PMU register handling on PV guests
Date: Fri, 26 Sep 2014 12:44:04 -0400
Message-ID: <542597D4.4070009@oracle.com>
References: <1411673336-32736-1-git-send-email-boris.ostrovsky@oracle.com>
	<1411673336-32736-16-git-send-email-boris.ostrovsky@oracle.com>
	<20140926163436.GE14378@laptop.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20140926163436.GE14378@laptop.dumpdata.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: kevin.tian@intel.com, keir@xen.org, jbeulich@suse.com, jun.nakajima@intel.com, andrew.cooper3@citrix.com, tim@xen.org, dietmar.hahn@ts.fujitsu.com, xen-devel@lists.xen.org, Aravind.Gopalakrishnan@amd.com, suravee.suthikulpanit@amd.com, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org

On 09/26/2014 12:34 PM, Konrad Rzeszutek Wilk wrote:
>> diff --git a/xen/include/public/pmu.h b/xen/include/public/pmu.h
>> index b8c5682..68a5fb8 100644
>> --- a/xen/include/public/pmu.h
>> +++ b/xen/include/public/pmu.h
>> @@ -27,6 +27,7 @@
>>   #define XENPMU_feature_set     3
>>   #define XENPMU_init            4
>>   #define XENPMU_finish          5
>> +#define XENPMU_lvtpc_set       6
> You also need this:

Right, this slipped into the next patch (#16).

-boris

>
>
>
> diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h
> index 29dae2e..d98256c 100644
> --- a/xen/include/xsm/dummy.h
> +++ b/xen/include/xsm/dummy.h
> @@ -664,7 +664,8 @@ static XSM_INLINE int xsm_pmu_op (XSM_DEFAULT_ARG struct domain *d, int op)
>       case XENPMU_feature_get:
>           return xsm_default_action(XSM_PRIV, d, current->domain);
>       case XENPMU_init:
> -    case XENPMU_finish:
> +    case XENPMU_finish:
> +    case XENPMU_lvtpc_set:
>           return xsm_default_action(XSM_HOOK, d, current->domain);
>       default:
>           return -EPERM;
> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c
> index 8bd4a3d..d89a857 100644
> --- a/xen/xsm/flask/hooks.c
> +++ b/xen/xsm/flask/hooks.c
> @@ -1500,6 +1500,7 @@ static int flask_pmu_op (struct domain *d, int op)
>                               XEN2__PMU_CTRL, NULL);
>       case XENPMU_init:
>       case XENPMU_finish:
> +    case XENPMU_lvtpc_set:
>           return avc_has_perm(dsid, SECINITSID_XEN, SECCLASS_XEN2,
>                               XEN2__PMU_USE, NULL);
>       default: