From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [RFC][PATCH 1/1] Add IOREQ_TYPE_VMWARE_PORT
Date: Mon, 29 Sep 2014 13:13:47 +0200
Message-ID: <54293EEB.7000401@redhat.com>
References: <1411757470-29337-1-git-send-email-dslutz@verizon.com>
	<1411757470-29337-2-git-send-email-dslutz@verizon.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1411757470-29337-2-git-send-email-dslutz@verizon.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org
Cc: Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

Il 26/09/2014 20:51, Don Slutz ha scritto:
> +    memcpy(&regs->rax, &vio->io_data, vio->io_size);

Shouldn't this match the code you use below for case
HVMIO_handle_vmport_awaiting_completion?

Paolo

> +    return X86EMUL_OKAY;
> +}
> +
>  static int hvmemul_do_io(
>      int is_mmio, paddr_t addr, unsigned long *reps, int size,
>      paddr_t ram_gpa, int dir, int df, void *p_data)
> diff --git a/xen/arch/x86/hvm/io.c b/xen/arch/x86/hvm/io.c
> index 9f565d6..96ef3ff 100644
> --- a/xen/arch/x86/hvm/io.c
> +++ b/xen/arch/x86/hvm/io.c
> @@ -206,6 +206,25 @@ void hvm_io_assist(ioreq_t *p)
>          else
>              memcpy(&guest_cpu_user_regs()->rax, &p->data, vio->io_size);
>          break;
> +    case HVMIO_handle_vmport_awaiting_completion:
> +    {
> +        struct cpu_user_regs *regs = guest_cpu_user_regs();
> +
> +        /* Always zero extension for eax */
> +        regs->rax = (uint32_t)(p->addr >> 32);
> +        /* Only zero extension if 32bit register changed */
> +        if ( (uint32_t)regs->rbx != (uint32_t)p->addr )
> +            regs->rbx = (uint32_t)p->addr;
> +        if ( (uint32_t)regs->rcx != (uint32_t)p->count )
> +            regs->rcx = (uint32_t)p->count;
> +        if ( (uint32_t)regs->rdx != (uint32_t)p->size )
> +            regs->rdx = (uint32_t)p->size;
> +        if ( (uint32_t)regs->rsi != (uint32_t)(p->data >> 32) )
> +            regs->rsi = (uint32_t)(p->data >> 32);
> +        if ( (uint32_t)regs->rdi != (uint32_t)p->data )
> +            regs->rdi = (uint32_t)p->data;
> +    }