From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for-4.5 v11 1/9] xen/arm: p2m changes for mem_access support Date: Mon, 29 Sep 2014 13:26:46 +0100 Message-ID: <54295006.9070809@linaro.org> References: <1411990609-22374-1-git-send-email-tklengyel@sec.in.tum.de> <1411990609-22374-2-git-send-email-tklengyel@sec.in.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1411990609-22374-2-git-send-email-tklengyel@sec.in.tum.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel , xen-devel@lists.xen.org Cc: tim@xen.org, dgdegra@tycho.nsa.gov, wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Tamas, On 09/29/2014 12:36 PM, Tamas K Lengyel wrote: > unsigned long gmfn_to_mfn(struct domain *d, unsigned long gpfn) > diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h > index 787e93c..3d69152 100644 > --- a/xen/include/asm-arm/domain.h > +++ b/xen/include/asm-arm/domain.h > @@ -17,6 +17,7 @@ struct hvm_domain > { > uint64_t params[HVM_NR_PARAMS]; > struct hvm_iommu iommu; > + bool_t introspection_enabled; Sorry, I haven't catch it before... This field is used by the common code, can't it be moved in xen/domain.h? Maybe protected by an #ifdef. I'm fine, if the code movement is done in a follow-up patch. So: Reviewed-by: Julien Grall Regards, -- Julien Grall