From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH for-4.5 v11 9/9] tools/tests: Enable
 xen-access on ARM
Date: Mon, 29 Sep 2014 15:16:22 +0100
Message-ID: <542969B6.6070104@linaro.org>
References: <1411990609-22374-1-git-send-email-tklengyel@sec.in.tum.de>
	<1411990609-22374-10-git-send-email-tklengyel@sec.in.tum.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1411990609-22374-10-git-send-email-tklengyel@sec.in.tum.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tamas K Lengyel <tklengyel@sec.in.tum.de>, xen-devel@lists.xen.org
Cc: tim@xen.org, dgdegra@tycho.nsa.gov, wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

Hello Tamas,

On 09/29/2014 12:36 PM, Tamas K Lengyel wrote:
> Define the ARM specific test_and_set_bit functions and switch
> to use maximum gpfn as the limit to setting permissions. Also,
> move HAS_MEM_ACCESS definition into config.
> 
> Signed-off-by: Tamas K Lengyel <tklengyel@sec.in.tum.de>
> ---
> v6: - Just use xc_domain_maximum_gpfn to get max_gpfn.
> v5: - Use the new information returned by getdomaininfo, max_gpfn, to
>       set access permissions. On ARM this will include the potential
>       memory hole as well which the hypervisor just loops over.
> v4: - Take into account multiple guest ram banks on ARM.
>     - Move HAS_MEM_ACCESS definition into config/*.mk and only compile
>       xen-access when it is defined.
>     - Pass CONFIG_X86/CONFIG_ARM flags during compilation in xen-access
>       Makefile.
> ---
>  tools/tests/xen-access/Makefile     |  9 ++++-
>  tools/tests/xen-access/xen-access.c | 79 ++++++++++++++++++++++++-------------
>  2 files changed, 59 insertions(+), 29 deletions(-)
> 
> diff --git a/tools/tests/xen-access/Makefile b/tools/tests/xen-access/Makefile
> index 65eef99..5056972 100644
> --- a/tools/tests/xen-access/Makefile
> +++ b/tools/tests/xen-access/Makefile
> @@ -7,8 +7,13 @@ CFLAGS += $(CFLAGS_libxenctrl)
>  CFLAGS += $(CFLAGS_libxenguest)
>  CFLAGS += $(CFLAGS_xeninclude)
>  
> -TARGETS-y := 
> -TARGETS-$(CONFIG_X86) += xen-access
> +CFLAGS-y :=
> +CFLAGS-$(CONFIG_X86) := -DCONFIG_X86
> +CFLAGS-$(CONFIG_ARM) := -DCONFIG_ARM

Hmmm ... why do you need those flags?

Can't you directly use __aarch64__, __arm__, __i386__ and __x86_64__?

Regards,

-- 
Julien Grall