[PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD

[PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD

[Roger Pau Monne]

FreeBSD doesn't use any qemu-ifup script in order to setup the network, it
is all done on the hotplug script like Linux.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
I request a code freeze exception on the basis that this is a bugfix and it
doesn't change the behaviour on platforms different than FreeBSD.
---
 tools/libxl/libxl_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index fbc82fd..0018113 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -21,7 +21,7 @@
 
 static const char *libxl_tapif_script(libxl__gc *gc)
 {
-#ifdef __linux__
+#if defined(__linux__) || defined(__FreeBSD__)
     return libxl__strdup(gc, "no");
 #else
     return libxl__sprintf(gc, "%s/qemu-ifup", libxl__xen_script_dir_path());
-- 
1.9.3 (Apple Git-50)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD

[Konrad Rzeszutek Wilk]

On Fri, Sep 26, 2014 at 06:14:12PM +0200, Roger Pau Monne wrote:
> FreeBSD doesn't use any qemu-ifup script in order to setup the network, it
> is all done on the hotplug script like Linux.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> I request a code freeze exception on the basis that this is a bugfix and it
> doesn't change the behaviour on platforms different than FreeBSD.

<nods>

Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

> ---
>  tools/libxl/libxl_dm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index fbc82fd..0018113 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -21,7 +21,7 @@
>  
>  static const char *libxl_tapif_script(libxl__gc *gc)
>  {
> -#ifdef __linux__
> +#if defined(__linux__) || defined(__FreeBSD__)
>      return libxl__strdup(gc, "no");
>  #else
>      return libxl__sprintf(gc, "%s/qemu-ifup", libxl__xen_script_dir_path());
> -- 
> 1.9.3 (Apple Git-50)
> 

Re: [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD

[Wei Liu]

On Fri, Sep 26, 2014 at 06:14:12PM +0200, Roger Pau Monne wrote:
> FreeBSD doesn't use any qemu-ifup script in order to setup the network, it
> is all done on the hotplug script like Linux.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

Re: [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD

[Ian Campbell]

On Fri, 2014-09-26 at 14:07 -0400, Konrad Rzeszutek Wilk wrote:
> On Fri, Sep 26, 2014 at 06:14:12PM +0200, Roger Pau Monne wrote:
> > FreeBSD doesn't use any qemu-ifup script in order to setup the network, it
> > is all done on the hotplug script like Linux.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Cc: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Wei Liu <wei.liu2@citrix.com>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > ---
> > I request a code freeze exception on the basis that this is a bugfix and it
> > doesn't change the behaviour on platforms different than FreeBSD.
> 
> <nods>
> 
> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Applied.

I'm wondering if anyone should be using qemu-ifup these days?



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD

[Roger Pau Monné]

El 29/09/14 a les 15.35, Ian Campbell ha escrit:
> On Fri, 2014-09-26 at 14:07 -0400, Konrad Rzeszutek Wilk wrote:
>> On Fri, Sep 26, 2014 at 06:14:12PM +0200, Roger Pau Monne wrote:
>>> FreeBSD doesn't use any qemu-ifup script in order to setup the network, it
>>> is all done on the hotplug script like Linux.
>>>
>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
>>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>>> Cc: Ian Campbell <ian.campbell@citrix.com>
>>> Cc: Wei Liu <wei.liu2@citrix.com>
>>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>> ---
>>> I request a code freeze exception on the basis that this is a bugfix and it
>>> doesn't change the behaviour on platforms different than FreeBSD.
>>
>> <nods>
>>
>> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> Applied.
> 
> I'm wondering if anyone should be using qemu-ifup these days?

AFAIR, NetBSD uses it for qemu-trad at least. I was tempted to invert
the ifdef and do something like:

#ifdef __NetBSD__
	... use qemu-ifup
#else
	... no ifup script
#endif

But I have no idea what Solaris does, or if we still try to support it.

Anyway, thanks for applying this.

Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD

[Ian Campbell]

On Mon, 2014-09-29 at 16:05 +0200, Roger Pau Monné wrote:
> El 29/09/14 a les 15.35, Ian Campbell ha escrit:
> > On Fri, 2014-09-26 at 14:07 -0400, Konrad Rzeszutek Wilk wrote:
> >> On Fri, Sep 26, 2014 at 06:14:12PM +0200, Roger Pau Monne wrote:
> >>> FreeBSD doesn't use any qemu-ifup script in order to setup the network, it
> >>> is all done on the hotplug script like Linux.
> >>>
> >>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> >>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> >>> Cc: Ian Campbell <ian.campbell@citrix.com>
> >>> Cc: Wei Liu <wei.liu2@citrix.com>
> >>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >>> ---
> >>> I request a code freeze exception on the basis that this is a bugfix and it
> >>> doesn't change the behaviour on platforms different than FreeBSD.
> >>
> >> <nods>
> >>
> >> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> > 
> > Applied.
> > 
> > I'm wondering if anyone should be using qemu-ifup these days?
> 
> AFAIR, NetBSD uses it for qemu-trad at least. I was tempted to invert
> the ifdef and do something like:
> 
> #ifdef __NetBSD__
> 	... use qemu-ifup
> #else
> 	... no ifup script
> #endif
> 
> But I have no idea what Solaris does, or if we still try to support it.

Do we/libxl not call the scripts too in those cases?

> Anyway, thanks for applying this.

NP.




_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD

[Roger Pau Monné]

El 29/09/14 a les 17.37, Ian Campbell ha escrit:
> On Mon, 2014-09-29 at 16:05 +0200, Roger Pau Monné wrote:
>> El 29/09/14 a les 15.35, Ian Campbell ha escrit:
>>> On Fri, 2014-09-26 at 14:07 -0400, Konrad Rzeszutek Wilk wrote:
>>>> On Fri, Sep 26, 2014 at 06:14:12PM +0200, Roger Pau Monne wrote:
>>>>> FreeBSD doesn't use any qemu-ifup script in order to setup the network, it
>>>>> is all done on the hotplug script like Linux.
>>>>>
>>>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>>>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
>>>>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>>>>> Cc: Ian Campbell <ian.campbell@citrix.com>
>>>>> Cc: Wei Liu <wei.liu2@citrix.com>
>>>>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>>>> ---
>>>>> I request a code freeze exception on the basis that this is a bugfix and it
>>>>> doesn't change the behaviour on platforms different than FreeBSD.
>>>>
>>>> <nods>
>>>>
>>>> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>>
>>> Applied.
>>>
>>> I'm wondering if anyone should be using qemu-ifup these days?
>>
>> AFAIR, NetBSD uses it for qemu-trad at least. I was tempted to invert
>> the ifdef and do something like:
>>
>> #ifdef __NetBSD__
>> 	... use qemu-ifup
>> #else
>> 	... no ifup script
>> #endif
>>
>> But I have no idea what Solaris does, or if we still try to support it.
> 
> Do we/libxl not call the scripts too in those cases?

Yes, the vif hotplug script is also called, but on NetBSD it just takes
care of adding the vif, not the tap interface.

I think it's done this way on NetBSD because tap interfaces cannot be
renamed, so only Qemu knows the actual unit/name of the tap interface
and calls the qemu-ifup script passing that name as the first argument.

Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD

[Ian Campbell]

On Mon, 2014-09-29 at 17:45 +0200, Roger Pau Monné wrote:
> El 29/09/14 a les 17.37, Ian Campbell ha escrit:
> > On Mon, 2014-09-29 at 16:05 +0200, Roger Pau Monné wrote:
> >> El 29/09/14 a les 15.35, Ian Campbell ha escrit:
> >>> On Fri, 2014-09-26 at 14:07 -0400, Konrad Rzeszutek Wilk wrote:
> >>>> On Fri, Sep 26, 2014 at 06:14:12PM +0200, Roger Pau Monne wrote:
> >>>>> FreeBSD doesn't use any qemu-ifup script in order to setup the network, it
> >>>>> is all done on the hotplug script like Linux.
> >>>>>
> >>>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> >>>>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> >>>>> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> >>>>> Cc: Ian Campbell <ian.campbell@citrix.com>
> >>>>> Cc: Wei Liu <wei.liu2@citrix.com>
> >>>>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >>>>> ---
> >>>>> I request a code freeze exception on the basis that this is a bugfix and it
> >>>>> doesn't change the behaviour on platforms different than FreeBSD.
> >>>>
> >>>> <nods>
> >>>>
> >>>> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >>>
> >>> Applied.
> >>>
> >>> I'm wondering if anyone should be using qemu-ifup these days?
> >>
> >> AFAIR, NetBSD uses it for qemu-trad at least. I was tempted to invert
> >> the ifdef and do something like:
> >>
> >> #ifdef __NetBSD__
> >> 	... use qemu-ifup
> >> #else
> >> 	... no ifup script
> >> #endif
> >>
> >> But I have no idea what Solaris does, or if we still try to support it.
> > 
> > Do we/libxl not call the scripts too in those cases?
> 
> Yes, the vif hotplug script is also called, but on NetBSD it just takes
> care of adding the vif, not the tap interface.
> 
> I think it's done this way on NetBSD because tap interfaces cannot be
> renamed, so only Qemu knows the actual unit/name of the tap interface
> and calls the qemu-ifup script passing that name as the first argument.

OK.



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel