From: Zheng Li <dev@zheng.li>
To: Dave Scott <Dave.Scott@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Joe Jin <joe.jin@oracle.com>,
"Luis R. Rodriguez" <mcgrof@suse.com>,
Luonengjun <luonengjun@huawei.com>,
Fanhenglong <fanhenglong@huawei.com>,
Ian Jackson <Ian.Jackson@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Liuqiming (John)" <john.liuqiming@huawei.com>
Subject: Re: Some oxenstored improvements (v3)
Date: Tue, 30 Sep 2014 11:21:20 +0100 [thread overview]
Message-ID: <542A8420.90205@zheng.li> (raw)
In-Reply-To: <B5CB2382-FBB0-4CCC-83B0-01833D1E1677@citrix.com>
On 29/09/2014 21:55, Dave Scott wrote:
> I’ve just read through the v3 patches and am happy with them. So I’m happy to give them an
>
> Acked-by: David Scott <dave.scott@citrix.com>
>
> I think this patch:
>
> [PATCH v3 4/9] oxenstored: catch the error when a connection is already deleted
>
> is a useful bug fix — this might explain why oxenstored has occasionally ‘disappeared’ in mysterious circumstances. Zheng: could this patch be taken by itself? If so I think the release should definitely have it.
Yes, [4/9] can be picked up by itself. It's a small patch and should be quite safe.
> The rest of the patches will help scalability a lot but aren’t critical fixes. They would (IMHO) increase the quality of the release though.
To group the these patches:
* [1/9], [2/9], and [3/9], are about select -> poll;
* [7/9] and [8/9] are about exhaustive ring scan -> selective ring scan, with [5/9] and [6/9] adding some facilities.
* [4/9] is a solo bug fix patch as stated;
* [9/9] is a solo perf improvement patch on syslog load.
Cheers,
Zheng
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-09-30 10:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 17:34 Some oxenstored improvements (v3) Zheng Li
2014-09-25 17:34 ` [PATCH v3 1/9] oxenstored: add a poll-based select mechanism Zheng Li
2014-09-25 17:34 ` [PATCH v3 2/9] oxenstored: add facilities to raise the max open fds uplimit Zheng Li
2014-09-25 17:34 ` [PATCH v3 3/9] oxenstored: add a --use-select command line flag Zheng Li
2014-09-25 17:34 ` [PATCH v3 4/9] oxenstored: catch the error when a connection is already deleted Zheng Li
2014-09-25 17:34 ` [PATCH v3 5/9] oxenstored: use hash table to store socket connections Zheng Li
2014-09-25 17:34 ` [PATCH v3 6/9] oxenstored: enable domain connection indexing based on eventchn port Zheng Li
2014-09-25 17:35 ` [PATCH v3 7/9] oxenstored: only process domain connections that notify us by events Zheng Li
2014-09-25 17:35 ` [PATCH v3 8/9] oxenstored: add a safe net mechanism for existing ill-behaved clients Zheng Li
2014-09-25 17:35 ` [PATCH v3 9/9] oxenstored: reduce syslog call overhead Zheng Li
2014-09-25 21:00 ` [PATCH v3 9/9] oxenstored: reduce syslog call overhead (fix typo) Zheng Li
2014-09-26 15:16 ` Ian Jackson
2014-09-26 15:33 ` Zheng Li
2014-09-26 15:57 ` Ian Jackson
2014-09-26 16:29 ` Zheng Li
2014-09-26 16:37 ` Ian Jackson
2014-09-26 16:38 ` Zheng Li
2014-09-29 14:37 ` Some oxenstored improvements (v3) Konrad Rzeszutek Wilk
2014-09-29 20:55 ` Dave Scott
2014-09-30 10:21 ` Zheng Li [this message]
2014-10-07 13:24 ` Konrad Rzeszutek Wilk
2014-10-08 12:59 ` Dave Scott
2014-10-08 13:01 ` Konrad Rzeszutek Wilk
2014-10-08 13:42 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542A8420.90205@zheng.li \
--to=dev@zheng.li \
--cc=Dave.Scott@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=fanhenglong@huawei.com \
--cc=joe.jin@oracle.com \
--cc=john.liuqiming@huawei.com \
--cc=konrad.wilk@oracle.com \
--cc=luonengjun@huawei.com \
--cc=mcgrof@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).