From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: stefano.stabellini@citrix.com, tim@xen.org, ian.campbell@citrix.com
Subject: Re: [PATCH v4 for 4.5] xen/arm: Correctly support WARN_ON
Date: Tue, 30 Sep 2014 17:45:05 +0100 [thread overview]
Message-ID: <542ADE11.3070100@linaro.org> (raw)
In-Reply-To: <1412095364-2498-1-git-send-email-julien.grall@linaro.org>
On 09/30/2014 05:42 PM, Julien Grall wrote:
> Currently the hypervisor will hang if it hits a WARN_ON.
>
> The implemention uses an undefined instruction, made ourself because ARM
> doesn't provide one, to implement BUG/ASSERT/WARN_ON, and sets up the
> different tables (one for each type) which contain useful information.
>
> This is based on the x86 implementation (include/asm-x86/bug.h). Unfortunately
> the structure can't be shared because many ARM{32,64} gcc versions doesn't
> correctly support %c. The support of executing a function in an exception handler
> is also keep unimplemented on ARM. Therefore, dump_execution_state is
> implement as WARN()
>
> The current opcode used to go in exception mode may not be undefined on ARM64.
> Use the instruction "brk" to generate a software debug exception.
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
Hmmm... I forgot to fix the typoes in the commit message. I will send a
new version quickly.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-09-30 16:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 16:42 [PATCH v4 for 4.5] xen/arm: Correctly support WARN_ON Julien Grall
2014-09-30 16:45 ` Julien Grall [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-09-30 16:47 Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542ADE11.3070100@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).