From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 for 4.5] xen/arm: Correctly support WARN_ON Date: Tue, 30 Sep 2014 17:45:05 +0100 Message-ID: <542ADE11.3070100@linaro.org> References: <1412095364-2498-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XZ0Y5-0002WD-HL for xen-devel@lists.xenproject.org; Tue, 30 Sep 2014 16:45:13 +0000 Received: by mail-wg0-f42.google.com with SMTP id z12so4885497wgg.13 for ; Tue, 30 Sep 2014 09:45:11 -0700 (PDT) In-Reply-To: <1412095364-2498-1-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: stefano.stabellini@citrix.com, tim@xen.org, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On 09/30/2014 05:42 PM, Julien Grall wrote: > Currently the hypervisor will hang if it hits a WARN_ON. > > The implemention uses an undefined instruction, made ourself because ARM > doesn't provide one, to implement BUG/ASSERT/WARN_ON, and sets up the > different tables (one for each type) which contain useful information. > > This is based on the x86 implementation (include/asm-x86/bug.h). Unfortunately > the structure can't be shared because many ARM{32,64} gcc versions doesn't > correctly support %c. The support of executing a function in an exception handler > is also keep unimplemented on ARM. Therefore, dump_execution_state is > implement as WARN() > > The current opcode used to go in exception mode may not be undefined on ARM64. > Use the instruction "brk" to generate a software debug exception. > > Signed-off-by: Julien Grall Hmmm... I forgot to fix the typoes in the commit message. I will send a new version quickly. Regards, -- Julien Grall