From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86/APIC: don't make wrong implications on constants
Date: Wed, 1 Oct 2014 09:36:50 +0100 [thread overview]
Message-ID: <542BBD22.7050802@citrix.com> (raw)
In-Reply-To: <542BD7FD020000780003B5F0@mail.emea.novell.com>
On 01/10/14 09:31, Jan Beulich wrote:
>>>> On 01.10.14 at 10:15, <andrew.cooper3@citrix.com> wrote:
>> On 01/10/14 08:30, Jan Beulich wrote:
>>> For the physical APIC oprofile code was abusing APIC_DM_NMI as a mask.
>> I think you need a comma after APIC for this sentence to parse correctly.
> I had one there and the dropped it. I'm never really sure about the
> punctuation differences between German and English.
>
>>> For the virtual APIC a wrong assumption was made that LVTPC could be
> Wouldn't a comma then be needed after APIC here too?
Strictly speaking yes (and I thought so just after sending the email),
but "a wrong assumption" changes the structure sufficiently that it
isn't anything like as obvious.
~Andrew
next prev parent reply other threads:[~2014-10-01 8:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 7:30 [PATCH] x86/APIC: don't make wrong implications on constants Jan Beulich
2014-10-01 8:15 ` Andrew Cooper
2014-10-01 8:31 ` Jan Beulich
2014-10-01 8:36 ` Andrew Cooper [this message]
2014-10-01 8:41 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542BBD22.7050802@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).