From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86/APIC: don't make wrong implications on constants Date: Wed, 1 Oct 2014 09:36:50 +0100 Message-ID: <542BBD22.7050802@citrix.com> References: <542BC9AE020000780003B53D@mail.emea.novell.com> <542BB831.1050003@citrix.com> <542BD7FD020000780003B5F0@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XZFP4-0000dH-PI for xen-devel@lists.xenproject.org; Wed, 01 Oct 2014 08:36:54 +0000 In-Reply-To: <542BD7FD020000780003B5F0@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , Boris Ostrovsky , Keir Fraser List-Id: xen-devel@lists.xenproject.org On 01/10/14 09:31, Jan Beulich wrote: >>>> On 01.10.14 at 10:15, wrote: >> On 01/10/14 08:30, Jan Beulich wrote: >>> For the physical APIC oprofile code was abusing APIC_DM_NMI as a mask. >> I think you need a comma after APIC for this sentence to parse correctly. > I had one there and the dropped it. I'm never really sure about the > punctuation differences between German and English. > >>> For the virtual APIC a wrong assumption was made that LVTPC could be > Wouldn't a comma then be needed after APIC here too? Strictly speaking yes (and I thought so just after sending the email), but "a wrong assumption" changes the structure sufficiently that it isn't anything like as obvious. ~Andrew