Re: [PATCH 1/3] xen/arm: Broadcom 7445D0 ARM cpu support.

[Julien Grall <julien.grall@linaro.org>]

Hello Jon,

Thank you for adding support to a new board in Xen.

I don't find a cover letter, so I will make general comments here.

It's common to CC the relevant maintainers on the different patches. So,
we can directly now that we are concerned with the series. You can use
scripts/get_maintainers.pl for this purpose.

Also, I've noticed that your patches are not arrived threaded in my box,
it's harder for us to know that every patches belongs to the same
series. git send-email *your list of patch* should do the job for you.


On 09/30/2014 11:57 PM, Jon Fraser wrote:
> Relax cpu id mask to cover minor cpu revisions in the SoC versions.
> 
> Signed-off-by: Jon Fraser <jfraser@broadcom.com>

Reviewed-by: Julien Grall <julien.grall@linaro.org>

> ---
>  xen/arch/arm/arm32/proc-v7.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/arm32/proc-v7.S b/xen/arch/arm/arm32/proc-v7.S
> index b0d5343..2f3ff1e 100644
> --- a/xen/arch/arm/arm32/proc-v7.S
> +++ b/xen/arch/arm/arm32/proc-v7.S
> @@ -50,8 +50,8 @@ __v7_ca7mp_proc_info:
>          .section ".init.proc.info", #alloc, #execinstr
>          .type __v7_brahma15mp_proc_info, #object
>  __v7_brahma15mp_proc_info:
> -        .long 0x420F00F2             /* Broadcom Brahma-B15 */
> -        .long 0xFF0FFFFF             /* Mask */
> +        .long 0x420F00F0             /* Broadcom Brahma-B15 */
> +        .long 0xFF0FFFF0             /* Mask */
>          .long brahma15mp_init
>          .long caxx_processor
>          .size __v7_brahma15mp_proc_info, . - __v7_brahma15mp_proc_info
> 

Regards,


-- 
Julien Grall